Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/extensions/extension_devtools_bridge.cc

Issue 173480: DevTools: Remove base/values dependency from devtools. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.h ('k') | chrome/common/devtools_messages_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_devtools_bridge.cc
===================================================================
--- chrome/browser/extensions/extension_devtools_bridge.cc (revision 24604)
+++ chrome/browser/extensions/extension_devtools_bridge.cc (working copy)
@@ -85,17 +85,19 @@
void ExtensionDevToolsBridge::OnRpcMessage(const std::string& class_name,
const std::string& message_name,
- const std::string& msg) {
+ const std::string& param1,
+ const std::string& param2,
+ const std::string& param3) {
DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_UI);
// TODO(jamesr): Update the filtering and message creation logic once
// the TimelineAgent lands in WebKit.
if (class_name == kTimelineAgentClassName) {
if (message_name == kPageEventMessageName) {
- std::string json = StringPrintf("[{\"record\": \"%s\"}]", msg.c_str());
+ std::string json = StringPrintf("[{\"record\": \"%s\"}]", param1.c_str());
profile_->GetExtensionMessageService()->
DispatchEventToRenderers(on_page_event_name_, json);
} else if (message_name == kTabUrlChangeEventMessageName) {
- std::string json = StringPrintf("[{\"record\": \"%s\"}]", msg.c_str());
+ std::string json = StringPrintf("[{\"record\": \"%s\"}]", param1.c_str());
profile_->GetExtensionMessageService()->
DispatchEventToRenderers(on_tab_url_change_event_name_, json);
}
« no previous file with comments | « chrome/browser/extensions/extension_devtools_bridge.h ('k') | chrome/common/devtools_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698