Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: webkit/glue/webdevtoolsagent_impl.cc

Issue 173480: DevTools: Remove base/values dependency from devtools. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webdevtoolsagent_impl.h ('k') | webkit/glue/webdevtoolsclient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webdevtoolsagent_impl.cc
===================================================================
--- webkit/glue/webdevtoolsagent_impl.cc (revision 24604)
+++ webkit/glue/webdevtoolsagent_impl.cc (working copy)
@@ -22,7 +22,6 @@
#include <wtf/OwnPtr.h>
#undef LOG
-#include "base/values.h"
#include "webkit/api/public/WebDataSource.h"
#include "webkit/api/public/WebURL.h"
#include "webkit/api/public/WebURLRequest.h"
@@ -191,11 +190,11 @@
void WebDevToolsAgentImpl::DispatchMessageFromClient(
const std::string& class_name,
const std::string& method_name,
- const std::string& raw_msg) {
- OwnPtr<ListValue> message(
- static_cast<ListValue*>(DevToolsRpc::ParseMessage(raw_msg)));
+ const std::string& param1,
+ const std::string& param2,
+ const std::string& param3) {
if (ToolsAgentDispatch::Dispatch(
- this, class_name, method_name, *message.get())) {
+ this, class_name, method_name, param1, param2, param3)) {
return;
}
@@ -206,7 +205,7 @@
if (debugger_agent_impl_.get() &&
DebuggerAgentDispatch::Dispatch(
debugger_agent_impl_.get(), class_name, method_name,
- *message.get())) {
+ param1, param2, param3)) {
return;
}
}
@@ -223,8 +222,11 @@
void WebDevToolsAgentImpl::SendRpcMessage(
const std::string& class_name,
const std::string& method_name,
- const std::string& raw_msg) {
- delegate_->SendMessageToClient(class_name, method_name, raw_msg);
+ const std::string& param1,
+ const std::string& param2,
+ const std::string& param3) {
+ delegate_->SendMessageToClient(class_name, method_name, param1, param2,
+ param3);
}
void WebDevToolsAgentImpl::InitDevToolsAgentHost() {
« no previous file with comments | « webkit/glue/webdevtoolsagent_impl.h ('k') | webkit/glue/webdevtoolsclient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698