Issue 1733026: Support --gtest_filter for try jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1733026: Support --gtest_filter for try jobs. (Closed)

Created:
10 years, 7 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

Description

Support --gtest_filter for try jobs. BUG=17948 TEST=submit various try jobs with and without -t option Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46173

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -9 lines)			Patch
M	buildbot/scripts/master/factory/commands.py	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	buildbot/scripts/master/try_job_base.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	depot_tools/trychange.py	View	1	3 chunks	+15 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

+maruel LGTM http://codereview.chromium.org/1733026/diff/2001/3001 File buildbot/scripts/master/factory/commands.py (right): http://codereview.chromium.org/1733026/diff/2001/3001#newcode155 buildbot/scripts/master/factory/commands.py:155: def DoStepFilterTest(bStep): Add comment for what the ...

10 years, 7 months ago (2010-04-30 21:28:14 UTC) #1

vandebo (ex-Chrome)

http://codereview.chromium.org/1733026/diff/2001/3001 File buildbot/scripts/master/factory/commands.py (right): http://codereview.chromium.org/1733026/diff/2001/3001#newcode155 buildbot/scripts/master/factory/commands.py:155: def DoStepFilterTest(bStep): On 2010/04/30 21:28:14, Lei Zhang wrote: > ...

10 years, 7 months ago (2010-04-30 21:34:42 UTC) #2

M-A Ruel

10 years, 7 months ago (2010-05-01 01:25:45 UTC) #3

Please set BUG=17948

Eh, I should have done that a long time ago. Thanks!

lgtm

http://codereview.chromium.org/1733026/diff/6001/7003
File depot_tools/trychange.py (right):

http://codereview.chromium.org/1733026/diff/6001/7003#newcode690
depot_tools/trychange.py:690: # Prevent reitveld updates if we aren't running
all the tests.
rietveld

Expand Messages | Collapse Messages

Issue 1733026: Support --gtest_filter for try jobs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages