Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: depot_tools/trychange.py

Issue 1733026: Support --gtest_filter for try jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/scripts/master/try_job_base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: depot_tools/trychange.py
===================================================================
--- depot_tools/trychange.py (revision 46112)
+++ depot_tools/trychange.py (working copy)
@@ -263,8 +263,8 @@
values['revision'] = options.revision
if options.clobber:
values['clobber'] = 'true'
- if options.tests:
- values['tests'] = ','.join(options.tests)
+ if options.testfilter:
+ values['testfilter'] = ','.join(options.testfilter)
if options.root:
values['root'] = options.root
if options.patchlevel:
@@ -496,10 +496,14 @@
help="Override which project to use. Projects are defined "
"server-side to define what default bot set to use")
- # Override the list of tests to run, use multiple times to list many tests
- # (or comma separated)
- group.add_option("-t", "--tests", action="append",
- help=optparse.SUPPRESS_HELP)
+ group.add_option("-t", "--testfilter", action="append",
+ help="Add a gtest_filter to a test. Use multiple times to "
+ "specify filters for different tests. (i.e. "
+ "--testfilter base_unittests:ThreadTest.* "
+ "--testfilter ui_tests) If you specify any testfilters "
+ "the test results will not be reported in rietveld and "
+ "only tests with filters will run.")
+
parser.add_option_group(group)
group = optparse.OptionGroup(parser, "Patch to run")
@@ -683,6 +687,11 @@
else:
print('Results will be emailed to: ' + options.email)
+ # Prevent reitveld updates if we aren't running all the tests.
M-A Ruel 2010/05/01 01:25:45 rietveld
+ if options.testfilter is not None:
+ options.issue = None
+ options.patchset = None
+
# Send the patch.
if options.send_patch:
# If forced.
« no previous file with comments | « buildbot/scripts/master/try_job_base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698