Support --gtest_filter for try jobs.

depot_tools/trychange.py

 #!/usr/bin/python
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Client-side script to send a try job to the try server. It communicates to
 the try server by either writting to a svn repository or by directly connecting
 to the server by HTTP.
 """
 
 import datetime
@@ skipping 245 matching lines @@
   if options.email:
     values['email'] = options.email
   values['user'] = options.user
   values['name'] = options.name
   if options.bot:
     values['bot'] = ','.join(options.bot)
   if options.revision:
     values['revision'] = options.revision
   if options.clobber:
     values['clobber'] = 'true'
-  if options.tests:
-    values['tests'] = ','.join(options.tests)
+  if options.testfilter:
+    values['testfilter'] = ','.join(options.testfilter)
   if options.root:
     values['root'] = options.root
   if options.patchlevel:
     values['patchlevel'] = options.patchlevel
   if options.issue:
     values['issue'] = options.issue
   if options.patchset:
     values['patchset'] = options.patchset
   if options.target:
     values['target'] = options.target
@@ skipping 211 matching lines @@
                     help="Force a clobber before building; e.g. don't do an "
                          "incremental build")
   # TODO(maruel): help="Select a specific configuration, usually 'debug' or "
   #                    "'release'"
   group.add_option("--target", help=optparse.SUPPRESS_HELP)
 
   group.add_option("--project",
                    help="Override which project to use. Projects are defined "
                         "server-side to define what default bot set to use")
 
-  # Override the list of tests to run, use multiple times to list many tests
-  # (or comma separated)
-  group.add_option("-t", "--tests", action="append",
-                   help=optparse.SUPPRESS_HELP)
+  group.add_option("-t", "--testfilter", action="append",
+                   help="Add a gtest_filter to a test. Use multiple times to "
+                        "specify filters for different tests. (i.e. "
+                        "--testfilter base_unittests:ThreadTest.* "
+                        "--testfilter ui_tests) If you specify any testfilters "
+                        "the test results will not be reported in rietveld and "
+                        "only tests with filters will run.")
+
   parser.add_option_group(group)
 
   group = optparse.OptionGroup(parser, "Patch to run")
   group.add_option("-f", "--file", default=file_list, dest="files",
                    metavar="FILE", action="append",
                    help="Use many times to list the files to include in the "
                         "try, relative to the repository root")
   group.add_option("--diff",
                    help="File containing the diff to try")
   group.add_option("--url",
@@ skipping 163 matching lines @@
         options.name = 'Issue %s' % options.issue
       else:
         options.name = 'Unnamed'
         print('Note: use --name NAME to change the try job name.')
     if not options.email:
       parser.error('Using an anonymous checkout. Please use --email or set '
                    'the TRYBOT_RESULTS_EMAIL_ADDRESS environment variable.')
     else:
       print('Results will be emailed to: ' + options.email)
 
+    # Prevent reitveld updates if we aren't running all the tests.

[M-A Ruel, 2010/05/01 01:25:45]

rietveld

+    if options.testfilter is not None:
+      options.issue = None
+      options.patchset = None
+
     # Send the patch.
     if options.send_patch:
       # If forced.
       options.send_patch(options)
       PrintSuccess(options)
       return 0
     try:
       if can_http:
         _SendChangeHTTP(options)
         PrintSuccess(options)
         return 0
     except NoTryServerAccess:
       if not can_svn:
         raise
     _SendChangeSVN(options)
     PrintSuccess(options)
     return 0
   except (InvalidScript, NoTryServerAccess), e:
     if swallow_exception:
       return 1
     print e
     return 1
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(TryChange(None, [], False))