Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1732030: Replaced funky state machines with classes. This is in preparation of doing the same to gl_Bench. (Closed)

Created:
10 years, 7 months ago by Alexey Marinichev
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://git@chromiumos-git//autotest.git
Visibility:
Public.

Description

Replaced teartest state machines with classes. Fixed/commented out GLES2 code.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Got rid of static test list initialization, fixed USE_EGL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -117 lines) Patch
M client/deps/glbench/src/Makefile View 2 chunks +6 lines, -2 lines 0 comments Download
M client/deps/glbench/src/egl_stuff.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M client/deps/glbench/src/main.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M client/deps/glbench/src/main.cc View 10 chunks +16 lines, -3 lines 0 comments Download
M client/deps/glbench/src/teartest.h View 1 1 chunk +19 lines, -11 lines 0 comments Download
M client/deps/glbench/src/teartest.cc View 1 8 chunks +88 lines, -57 lines 0 comments Download
M client/deps/glbench/src/teartest_egl.cc View 1 1 chunk +15 lines, -4 lines 0 comments Download
M client/deps/glbench/src/teartest_glx.cc View 1 2 chunks +59 lines, -36 lines 0 comments Download
M client/deps/glbench/src/utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M client/deps/glbench/src/utils.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexey Marinichev
10 years, 7 months ago (2010-04-30 18:32:10 UTC) #1
piman
http://codereview.chromium.org/1732030/diff/1/3 File client/deps/glbench/src/teartest.cc (right): http://codereview.chromium.org/1732030/diff/1/3#newcode30 client/deps/glbench/src/teartest.cc:30: TestRegistry()->insert(std::pair<const char*, Test*>(name, t)); you can use std::make_pair(name, t) ...
10 years, 7 months ago (2010-04-30 19:44:02 UTC) #2
Alexey Marinichev
Also #ifdefed out stuff so that it compiles with GLES2/gl2.h. http://codereview.chromium.org/1732030/diff/1/4 File client/deps/glbench/src/teartest.h (right): http://codereview.chromium.org/1732030/diff/1/4#newcode12 ...
10 years, 7 months ago (2010-04-30 23:20:52 UTC) #3
piman
10 years, 7 months ago (2010-05-01 00:12:09 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698