Issue 173022: Possible deadlock in PCM audio Start() method...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173022: Possible deadlock in PCM audio Start() method... (Closed)

Created:
11 years, 4 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Possible deadlock in PCM audio Start() method - Implement Alpha's idea of pausing the device while we queue the first two packets. - This way we don't risk the chance to enter the callback from two threads at the same time. TEST=unit test added BUG=19276 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23668

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -6 lines)			Patch
	M	media/audio/win/audio_output_win_unittest.cc	View	1	3 chunks	+33 lines, -2 lines	0 comments	Download
	M	media/audio/win/waveout_output_win.cc	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

11 years, 4 months ago (2009-08-18 23:46:47 UTC) #3

Woohoo!

On Tue, Aug 18, 2009 at 3:16 PM, <hclam@chromium.org> wrote:

> LGTM. Thanks!
>
>
> http://codereview.chromium.org/173022
>

Expand Messages | Collapse Messages