Create new event_utils.h file for Cocoa-specific event to WindowOpenDispositi...

Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition cracking.

Hook this up to BookmarkBarController so that clicks to bookmark items use the oracle function to determine where the bookmark should be opened.

BUG=17301
TEST=Cmd+Click etc on bookmark items should work. See bug and unit test attached.

[John Grabowski, 2009-08-18 21:34:04]

LGTM

http://codereview.chromium.org/172082/diff/2001/2002
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/172082/diff/2001/2002#newcode27
Line 27: @interface BookmarkButton : NSButton {
No need for { and } if empty

http://codereview.chromium.org/172082/diff/2001/2002#newcode31
Line 31: @implementation BookmarkButton
Idea for unit test for this:

TEST_F(BookmarkBarControllerTest, MiddleClick) {
  BookmarkModel* model = helper_.profile()->GetBookmarkModel();
  GURL gurl1("http://www.google.com");
  std::wstring title1(L"x");
  model->SetURLStarred(gurl1, title1, true);

  EXPECT_EQ(1U, [[bar_ buttons] count]);
  NSButton* first = [[bar_ buttons] objectAtIndex:0];
  EXPECT_TRUE(first);
  
  scoped_nsobject<BookmarkURLOpenerPong> pong([[BookmarkURLOpenerPong alloc]
                                                init]);
  [bar_ setUrlDelegate:pong.get()];
  [first otherMouseUp:[NSEvent .... /* TODO */]];
  EXPECT_EQ(pong.get()->urls_.length(), 1);
  [bar_ setUrlDelegate:nil];
}

http://codereview.chromium.org/172082/diff/2001/2004
File chrome/browser/cocoa/event_utils_unittest.mm (right):

http://codereview.chromium.org/172082/diff/2001/2004#newcode11
Line 11: class EventUtilsTest : public testing::Test {
i <3 u 4 dis

http://codereview.chromium.org/172082/diff/2001/2004#newcode55
Line 55: TODO(beng): figure out how to synthesize a Shift+Middle Click.
Idea sent in email; method_exchangeImplementations()

[Ben Goodger (Google), 2009-08-18 21:35:56]

Working on an update for this CL, will have it posted soon.

-Ben

On Tue, Aug 18, 2009 at 2:34 PM, <jrg@chromium.org> wrote:
> LGTM
>
>
>
> http://codereview.chromium.org/172082/diff/2001/2002
> File chrome/browser/cocoa/bookmark_bar_controller.mm (right):
>
> http://codereview.chromium.org/172082/diff/2001/2002#newcode27
> Line 27: @interface BookmarkButton : NSButton {
> No need for { and } if empty
>
> http://codereview.chromium.org/172082/diff/2001/2002#newcode31
> Line 31: @implementation BookmarkButton
> Idea for unit test for this:
>
> TEST_F(BookmarkBarControllerTest, MiddleClick) {
> =A0BookmarkModel* model =3D helper_.profile()->GetBookmarkModel();
> =A0GURL gurl1("http://www.google.com");
> =A0std::wstring title1(L"x");
> =A0model->SetURLStarred(gurl1, title1, true);
>
> =A0EXPECT_EQ(1U, [[bar_ buttons] count]);
> =A0NSButton* first =3D [[bar_ buttons] objectAtIndex:0];
> =A0EXPECT_TRUE(first);
>
> =A0scoped_nsobject<BookmarkURLOpenerPong> pong([[BookmarkURLOpenerPong
> alloc]
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0init]);
> =A0[bar_ setUrlDelegate:pong.get()];
> =A0[first otherMouseUp:[NSEvent .... /* TODO */]];
> =A0EXPECT_EQ(pong.get()->urls_.length(), 1);
> =A0[bar_ setUrlDelegate:nil];
> }
>
> http://codereview.chromium.org/172082/diff/2001/2004
> File chrome/browser/cocoa/event_utils_unittest.mm (right):
>
> http://codereview.chromium.org/172082/diff/2001/2004#newcode11
> Line 11: class EventUtilsTest : public testing::Test {
> i <3 u 4 dis
>
> http://codereview.chromium.org/172082/diff/2001/2004#newcode55
> Line 55: TODO(beng): figure out how to synthesize a Shift+Middle Click.
> Idea sent in email; method_exchangeImplementations()
>
> http://codereview.chromium.org/172082
>

[Ben Goodger (Google), 2009-08-18 22:12:27]

Updated.

On Tue, Aug 18, 2009 at 2:35 PM, Ben Goodger (Google)<ben@chromium.org> wro=
te:
> Working on an update for this CL, will have it posted soon.
>
> -Ben
>
> On Tue, Aug 18, 2009 at 2:34 PM, <jrg@chromium.org> wrote:
>> LGTM
>>
>>
>>
>> http://codereview.chromium.org/172082/diff/2001/2002
>> File chrome/browser/cocoa/bookmark_bar_controller.mm (right):
>>
>> http://codereview.chromium.org/172082/diff/2001/2002#newcode27
>> Line 27: @interface BookmarkButton : NSButton {
>> No need for { and } if empty
>>
>> http://codereview.chromium.org/172082/diff/2001/2002#newcode31
>> Line 31: @implementation BookmarkButton
>> Idea for unit test for this:
>>
>> TEST_F(BookmarkBarControllerTest, MiddleClick) {
>> =A0BookmarkModel* model =3D helper_.profile()->GetBookmarkModel();
>> =A0GURL gurl1("http://www.google.com");
>> =A0std::wstring title1(L"x");
>> =A0model->SetURLStarred(gurl1, title1, true);
>>
>> =A0EXPECT_EQ(1U, [[bar_ buttons] count]);
>> =A0NSButton* first =3D [[bar_ buttons] objectAtIndex:0];
>> =A0EXPECT_TRUE(first);
>>
>> =A0scoped_nsobject<BookmarkURLOpenerPong> pong([[BookmarkURLOpenerPong
>> alloc]
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0init]);
>> =A0[bar_ setUrlDelegate:pong.get()];
>> =A0[first otherMouseUp:[NSEvent .... /* TODO */]];
>> =A0EXPECT_EQ(pong.get()->urls_.length(), 1);
>> =A0[bar_ setUrlDelegate:nil];
>> }
>>
>> http://codereview.chromium.org/172082/diff/2001/2004
>> File chrome/browser/cocoa/event_utils_unittest.mm (right):
>>
>> http://codereview.chromium.org/172082/diff/2001/2004#newcode11
>> Line 11: class EventUtilsTest : public testing::Test {
>> i <3 u 4 dis
>>
>> http://codereview.chromium.org/172082/diff/2001/2004#newcode55
>> Line 55: TODO(beng): figure out how to synthesize a Shift+Middle Click.
>> Idea sent in email; method_exchangeImplementations()
>>
>> http://codereview.chromium.org/172082
>>
>

[John Grabowski, 2009-08-18 22:30:56]

Still LGTM

http://codereview.chromium.org/172082/diff/2024/3005
File chrome/browser/cocoa/event_utils_unittest.mm (right):

http://codereview.chromium.org/172082/diff/2024/3005#newcode12
Line 12: @interface TestEvent : NSObject
Brief comment explaining that there is no way to otherwise create a
shift-middle-click.