Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: chrome/common/cocoa_utils.mm

Issue 172082: Create new event_utils.h file for Cocoa-specific event to WindowOpenDispositi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/cocoa_utils.h ('k') | chrome/common/cocoa_utils_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/cocoa_utils.mm
===================================================================
--- chrome/common/cocoa_utils.mm (revision 23676)
+++ chrome/common/cocoa_utils.mm (working copy)
@@ -1,26 +0,0 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "chrome/common/cocoa_utils.h"
-
-namespace event_utils {
-
-// Translates modifier flags from an NSEvent into a WindowOpenDisposition. For
-// example, holding down Cmd (Apple) will cause pages to be opened in a new
-// foreground tab. Pass this the result of -[NSEvent modifierFlags].
-WindowOpenDisposition DispositionFromEventFlags(NSUInteger modifiers) {
- if (modifiers & NSCommandKeyMask) {
- return (modifiers & NSShiftKeyMask) ?
- NEW_BACKGROUND_TAB : NEW_FOREGROUND_TAB;
- }
-
- if (modifiers & NSShiftKeyMask)
- return NEW_WINDOW;
- // TODO: Browser::OpenURLAtIndex does not support SAVE_TO_DISK, so we can't
- // offer to download the page. See DCHECK() and TODOs there.
- return (false /* modifiers & NSAlternateKeyMask */) ?
- SAVE_TO_DISK : CURRENT_TAB;
-}
-
-} // namespace event_utils
« no previous file with comments | « chrome/common/cocoa_utils.h ('k') | chrome/common/cocoa_utils_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698