Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 171007: Fix a FORWARD_NULL defect reported by Coverity.... (Closed)

Created:
11 years, 4 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
brettw, Evan Stade
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Fix a FORWARD_NULL defect reported by Coverity. If 'profile' is NULL, we should return ResultCodes::NORMAL_EXIT so that we won't go on to dereference 'profile'. R=brettw,estade BUG=http://crbug.com/17101 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24469

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
wtc
http://codereview.chromium.org/171007/diff/1/2 File chrome/browser/browser_main.cc (left): http://codereview.chromium.org/171007/diff/1/2#oldcode542 Line 542: #endif // defined(OS_WIN) || defined(OS_LINUX) An alternative is ...
11 years, 4 months ago (2009-08-15 00:22:38 UTC) #1
Evan Stade
I also don't know what's right for mac but this seems fine to me.
11 years, 4 months ago (2009-08-15 00:35:00 UTC) #2
brettw
11 years, 4 months ago (2009-08-15 17:54:42 UTC) #3
LGTM 2

On Fri, Aug 14, 2009 at 5:35 PM, <estade@chromium.org> wrote:
> I also don't know what's right for mac but this seems fine to me.
>
> http://codereview.chromium.org/171007
>

Powered by Google App Engine
This is Rietveld 408576698