Fix a FORWARD_NULL defect reported by Coverity....

chrome/browser/browser_main.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 519 matching lines @@
     if (!user_data_dir.empty()) {
       // Because of the way CommandLine parses, it's sufficient to append a new
       // --user-data-dir switch.  The last flag of the same name wins.
       // TODO(tc): It would be nice to remove the flag we don't want, but that
       // sounds risky if we parse differently than CommandLineToArgvW.
       CommandLine new_command_line = parsed_command_line;
       new_command_line.AppendSwitchWithValue(switches::kUserDataDir,
                                              user_data_dir.ToWStringHack());
       base::LaunchApp(new_command_line, false, false, NULL);
     }
+#endif  // defined(OS_WIN) || defined(OS_LINUX)
 
     return ResultCodes::NORMAL_EXIT;
-#endif  // defined(OS_WIN) || defined(OS_LINUX)

[wtc, 2009/08/15 00:22:38]

An alternative is to add

+#else
+    return ResultCode::MISSING_DATA;  // or some other result code
 #endif  // defined(OS_WIN) || defined(OS_LINUX)

I don't know the code well enough to know what's the right
return code for Mac here.

   }
 
   PrefService* user_prefs = profile->GetPrefs();
   DCHECK(user_prefs);
 
   // Now that local state and user prefs have been loaded, make the two pref
   // services aware of all our preferences.
   browser::RegisterAllPrefs(user_prefs, local_state);
 
   // Now that all preferences have been registered, set the install date
@@ skipping 250 matching lines @@
   if (metrics)
     metrics->Stop();
 
   // browser_shutdown takes care of deleting browser_process, so we need to
   // release it.
   browser_process.release();
   browser_shutdown::Shutdown();
 
   return result_code;
 }