Issue 1706017: Crash: Moving bookmarks into subfolder in incognito window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1706017: Crash: Moving bookmarks into subfolder in incognito window (Closed)

Created:
10 years, 7 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
feldstein

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Crash: Moving bookmarks into subfolder in incognito window Fixes issue with bookmark hover where button target is dealloc'd without properly cancelling delayed hover button open. BUG=42051 TEST=Manual according to steps in bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45740

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages