Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm

Issue 1706017: Crash: Moving bookmarks into subfolder in incognito window (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm
diff --git a/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm b/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm
index 5d977e48d2187b3de3908e7a48e395f5cee32351..86d78bb428488b7475218fc32f86d808ffcd6671 100644
--- a/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm
+++ b/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm
@@ -38,12 +38,12 @@
[self scheduleCloseBookmarkFolderOnHoverButton];
} else if (hoverState_ == kHoverStateClosed) {
// Open the new.
- [self scheduleOpenBookmarkFolderOnHoverButton:[button retain]];
+ [self scheduleOpenBookmarkFolderOnHoverButton:button];
}
} else if (!hoverButton_) {
// CASE C: we don't have a current hoverButton_ but we have dragged onto
// a new folder so we open the new one.
- [self scheduleOpenBookmarkFolderOnHoverButton:[button retain]];
+ [self scheduleOpenBookmarkFolderOnHoverButton:button];
}
} else if (!button) {
if (hoverButton_) {
@@ -100,7 +100,7 @@
// Schedule open of hover button. Transition to kHoverStateOpening state.
- (void)scheduleOpenBookmarkFolderOnHoverButton:(BookmarkButton*)button {
DCHECK(button);
- hoverButton_.reset(button);
+ hoverButton_.reset([button retain]);
[self setHoverState:kHoverStateOpening];
[self performSelector:@selector(openBookmarkFolderOnHoverButton:)
withObject:hoverButton_
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698