chrome/browser/cocoa/bookmark_bar_folder_controller.mm - Issue 1706017: Crash: Moving bookmarks into subfolder in incognito window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Issue 1706017: Crash: Moving bookmarks into subfolder in incognito window (Closed)

Patch Set: Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/bookmark_bar_folder_controller.mm

diff --git a/chrome/browser/cocoa/bookmark_bar_folder_controller.mm b/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

index 861f6e2c4c1d18baf8e49607bfa1a3be77aefbe5..29d718595b760497894d59c9d0e127b90d4b88db 100644

--- a/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

+++ b/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

@@ -84,6 +84,7 @@ const CGFloat kScrollWindowVerticalMargin = 0.0;

- (void)dealloc {

[self removeScrollTracking];

[self endScroll];

+ [hoverState_ draggingExited];

// Note: we don't need to

// [NSObject cancelPreviousPerformRequestsWithTarget:self];

// Because all of our performSelector: calls use withDelay: which

« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm » ('j') | no next file with comments »