Issue 1687019: Fixed samples to work with resizing code introduced yesterday. Now the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1687019: Fixed samples to work with resizing code introduced yesterday. Now the... (Closed)

Created:
10 years, 8 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
petersont

CC:
o3d-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fixed samples to work with resizing code introduced yesterday. Now the setup of the containing div is identical to that in the plugin version of O3D. Fixed createClients to only call the initialization callback once the client's initial size has been set. Fixed bug in texture wrap mode setup which was breaking the bump map in helloworld.html. BUG=none TEST=ran all o3d-webgl samples TBR=petersont Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45866

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -13 lines)			Patch
M	samples/o3d-webgl-samples/hellocube.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl-samples/hellocube-colors.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl-samples/hellocube-textures.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl-samples/helloworld.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl-samples/primitives.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl-samples/shadow-map.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/o3d-webgl/pack.js	View	1 chunk	+3 lines, -6 lines	1 comment	Download
M	samples/o3d-webgl/texture.js	View	2 chunks	+34 lines, -0 lines	0 comments	Download
M	samples/o3djs/webgl.js	View	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petersont

10 years, 8 months ago (2010-04-28 22:24:17 UTC) #2

lgtm.

http://codereview.chromium.org/1687019/diff/3001/4003
File samples/o3d-webgl/pack.js (right):

http://codereview.chromium.org/1687019/diff/3001/4003#newcode217
samples/o3d-webgl/pack.js:217: this.gl.bindTexture(this.gl.TEXTURE_2D,
texture.texture_);
I will fix this differently in a cl I'm working on right now.

Expand Messages | Collapse Messages