ObjC classes generated by the build and used in Xib files is already getting ...

ObjC classes generated by the build and used in Xib files is already getting ugly, if they aren't built at build start, IB sometimes throws warnings about unknown things, so...
  - Use one class for the localizer and generate the table that drives it.
  - Update the generator script to process a list of xib files and generate one header.
  - Update the data within the GYP file to do this.
  - This might actually help overall size since it helps force one set of strings for each different window.
  - Switch to bsearch for table lookup since we have one, larger table now.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23017

[Mark Mentovai, 2009-08-10 19:05:55]

lgtm
nitty comments

http://codereview.chromium.org/164260/diff/1002/21
File build/mac/generate_localizer (left):

http://codereview.chromium.org/164260/diff/1002/21#oldcode27
Line 27: #ifndef %(class_name)s_LOCALIZER_H_
Getting rid of the #include guards?  Don't we want to keep them?

http://codereview.chromium.org/164260/diff/1002/21
File build/mac/generate_localizer (right):

http://codereview.chromium.org/164260/diff/1002/21#newcode22
Line 22: //
Now you should also say that nobody should be #including this file except for
ui_localizer.mm.

http://codereview.chromium.org/164260/diff/1002/21#newcode94
Line 94: xib_paths = argv[1:-1]
I'd put the output first and the inputs after that, because there's only one
output and there are a bunch of inputs.

http://codereview.chromium.org/164260/diff/1002/29
File chrome/browser/cocoa/ui_localizer.mm (right):

http://codereview.chromium.org/164260/diff/1002/29#newcode30
Line 30: const UILocalizerResourceMap *res_map =
const UILocalizerResourceMap* res_map =

Fix the parameters to this function too.

http://codereview.chromium.org/164260/diff/1002/29#newcode35
Line 35: }
// namespace

http://codereview.chromium.org/164260/diff/1002/29#newcode62
Line 62: // Include the table here so it is a local static (provides
kUIResources and
The parenthetical is better as its own sentence.  "Include the table here so it
is a local static.  This header provides kUIResources and kUIResourcesSize.

http://codereview.chromium.org/164260/diff/1002/29#newcode70
Line 70: kUIResources,
Too much indent

http://codereview.chromium.org/164260/diff/1002/29#newcode80
Line 80: l10n_util::GetStringUTF16(val->label_arg_id));
Do not break to new line here.