Issue 1623005: Removing BinaryOpIC::Clear. This method relied on some less-than-obvious hack...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1623005: Removing BinaryOpIC::Clear. This method relied on some less-than-obvious hack... (Closed)

Created:
10 years, 8 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
antonm, Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Removing BinaryOpIC::Clear. This method relied on some less-than-obvious hack, and there was zero (or small negative) performance advantage. Committed: http://code.google.com/p/v8/source/detail?r=4362

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -36 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+2 lines, -20 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 8 months ago (2010-04-08 13:36:05 UTC) #2

LGTM, thanks!

Isn't the ARM codegenerator missing, though?

Expand Messages | Collapse Messages