Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 1623005: Removing BinaryOpIC::Clear. This method relied on some less-than-obvious hack... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9050 matching lines...) Expand 10 before | Expand all | Expand 10 after
9061 break; 9061 break;
9062 case Token::SHL: 9062 case Token::SHL:
9063 __ InvokeBuiltin(Builtins::SHL, JUMP_FUNCTION); 9063 __ InvokeBuiltin(Builtins::SHL, JUMP_FUNCTION);
9064 break; 9064 break;
9065 case Token::SHR: 9065 case Token::SHR:
9066 __ InvokeBuiltin(Builtins::SHR, JUMP_FUNCTION); 9066 __ InvokeBuiltin(Builtins::SHR, JUMP_FUNCTION);
9067 break; 9067 break;
9068 default: 9068 default:
9069 UNREACHABLE(); 9069 UNREACHABLE();
9070 } 9070 }
9071
9072 // TODO(kaznacheev) Remove this (along with clearing) if it does not harm
9073 // performance.
9074 // Generate an unreachable reference to the DEFAULT stub so that it can be
9075 // found at the end of this stub when clearing ICs at GC.
9076 if (runtime_operands_type_ != BinaryOpIC::DEFAULT) {
9077 GenericBinaryOpStub uninit(MinorKey(), BinaryOpIC::DEFAULT);
9078 __ TailCallStub(&uninit);
9079 }
9080 } 9071 }
9081 9072
9082 9073
9083 void GenericBinaryOpStub::GenerateLoadArguments(MacroAssembler* masm) { 9074 void GenericBinaryOpStub::GenerateLoadArguments(MacroAssembler* masm) {
9084 ASSERT(!HasArgsInRegisters()); 9075 ASSERT(!HasArgsInRegisters());
9085 __ movq(rax, Operand(rsp, 1 * kPointerSize)); 9076 __ movq(rax, Operand(rsp, 1 * kPointerSize));
9086 __ movq(rdx, Operand(rsp, 2 * kPointerSize)); 9077 __ movq(rdx, Operand(rsp, 2 * kPointerSize));
9087 } 9078 }
9088 9079
9089 9080
(...skipping 976 matching lines...) Expand 10 before | Expand all | Expand 10 after
10066 // Call the function from C++. 10057 // Call the function from C++.
10067 return FUNCTION_CAST<ModuloFunction>(buffer); 10058 return FUNCTION_CAST<ModuloFunction>(buffer);
10068 } 10059 }
10069 10060
10070 #endif 10061 #endif
10071 10062
10072 10063
10073 #undef __ 10064 #undef __
10074 10065
10075 } } // namespace v8::internal 10066 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698