Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 1623005: Removing BinaryOpIC::Clear. This method relied on some less-than-obvious hack... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9500 matching lines...) Expand 10 before | Expand all | Expand 10 after
9511 break; 9511 break;
9512 case Token::SHL: 9512 case Token::SHL:
9513 __ InvokeBuiltin(Builtins::SHL, JUMP_FUNCTION); 9513 __ InvokeBuiltin(Builtins::SHL, JUMP_FUNCTION);
9514 break; 9514 break;
9515 case Token::SHR: 9515 case Token::SHR:
9516 __ InvokeBuiltin(Builtins::SHR, JUMP_FUNCTION); 9516 __ InvokeBuiltin(Builtins::SHR, JUMP_FUNCTION);
9517 break; 9517 break;
9518 default: 9518 default:
9519 UNREACHABLE(); 9519 UNREACHABLE();
9520 } 9520 }
9521
9522 // Generate an unreachable reference to the DEFAULT stub so that it can be
9523 // found at the end of this stub when clearing ICs at GC.
9524 if (runtime_operands_type_ != BinaryOpIC::DEFAULT) {
9525 GenericBinaryOpStub uninit(MinorKey(), BinaryOpIC::DEFAULT);
9526 __ TailCallStub(&uninit);
9527 }
9528 } 9521 }
9529 9522
9530 9523
9531 void GenericBinaryOpStub::GenerateHeapResultAllocation(MacroAssembler* masm, 9524 void GenericBinaryOpStub::GenerateHeapResultAllocation(MacroAssembler* masm,
9532 Label* alloc_failure) { 9525 Label* alloc_failure) {
9533 Label skip_allocation; 9526 Label skip_allocation;
9534 OverwriteMode mode = mode_; 9527 OverwriteMode mode = mode_;
9535 if (HasArgsReversed()) { 9528 if (HasArgsReversed()) {
9536 if (mode == OVERWRITE_RIGHT) { 9529 if (mode == OVERWRITE_RIGHT) {
9537 mode = OVERWRITE_LEFT; 9530 mode = OVERWRITE_LEFT;
(...skipping 3114 matching lines...) Expand 10 before | Expand all | Expand 10 after
12652 12645
12653 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater) 12646 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater)
12654 // tagged as a small integer. 12647 // tagged as a small integer.
12655 __ bind(&runtime); 12648 __ bind(&runtime);
12656 __ TailCallRuntime(Runtime::kStringCompare, 2, 1); 12649 __ TailCallRuntime(Runtime::kStringCompare, 2, 1);
12657 } 12650 }
12658 12651
12659 #undef __ 12652 #undef __
12660 12653
12661 } } // namespace v8::internal 12654 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698