Add files to browser/sync.

Add files to browser/sync and tweak includes.
Create browser/sync/glue and /engine.
Create sync watchlist and add a few folks.

No GYP change here so no build changes should occur.
chrome.gyp CL is coming shortly, as well as live_sync tests.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22454

[tim (not reviewing), 2009-08-04 20:58:49]

Added files under browser/views and browser/dom_ui as well as I forgot to paste
them into the CL.

On 2009/08/04 20:33:48, timsteele wrote:
>

[ncarter (slow), 2009-08-04 22:17:39]

http://codereview.chromium.org/160598/diff/261/293
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/160598/diff/261/293#newcode43
Line 43: <include file="sync\resources\about_sync.html" flattenhtml="true"
name="IDR_ABOUT_SYNC_HTML" type="BINDATA"/>
the tag attributes are ordered differently from the rest of the file.

http://codereview.chromium.org/160598/diff/261/293#newcode44
Line 44: <include file="sync\resources\gaia_login.html" flattenhtml="true"
name="IDR_GAIA_LOGIN_HTML" type="BINDATA"/>
The rest of the file uses a space before the closing "/>".

http://codereview.chromium.org/160598/diff/261/305
File chrome/browser/dom_ui/new_tab_page_sync_handler.cc (right):

http://codereview.chromium.org/160598/diff/261/305#newcode7
Line 7: #include "chrome/personalization/dom_ui/new_tab_page_sync_handler.h"
eh?

http://codereview.chromium.org/160598/diff/261/305#newcode18
Line 18: #include "chrome/personalization/personalization_strings.h"
eh?

http://codereview.chromium.org/160598/diff/261/294
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/160598/diff/261/294#newcode47
Line 47: #include "chrome/browser/sync/personalization.h"
Sort.

http://codereview.chromium.org/160598/diff/261/291
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/160598/diff/261/291#newcode21
Line 21: #include "chrome/browser/sync/personalization.h"
Sort.

http://codereview.chromium.org/160598/diff/261/263
File chrome/browser/profile.h (right):

http://codereview.chromium.org/160598/diff/261/263#newcode20
Line 20: #include "chrome/browser/sync/personalization.h"
Sort.

http://codereview.chromium.org/160598/diff/261/268
File chrome/browser/sync/auth_error_state.h (right):

http://codereview.chromium.org/160598/diff/261/268#newcode5
Line 5: #ifndef CHROME_PERSONALIZATION_AUTH_ERROR_STATE_H_
CHROME_BROWSER_SYNC_AUTH_ERROR_STATE_H_

http://codereview.chromium.org/160598/diff/261/289
File chrome/browser/sync/glue/model_associator.h (right):

http://codereview.chromium.org/160598/diff/261/289#newcode25
Line 25: };
nit: no semicolon.

http://codereview.chromium.org/160598/diff/261/289#newcode41
Line 41: // Clears all assocations .
nit: extra space.

http://codereview.chromium.org/160598/diff/261/273
File chrome/browser/sync/personalization.cc (right):

http://codereview.chromium.org/160598/diff/261/273#newcode339
Line 339: #endif
#endif  // CHROME_PERSONALIZATION

http://codereview.chromium.org/160598/diff/261/270
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/160598/diff/261/270#newcode28
Line 28: #include "chrome/browser/sync/engine/syncapi.h"
Sort.

http://codereview.chromium.org/160598/diff/261/266
File chrome/browser/sync/profile_sync_service_unittest.cc (right):

http://codereview.chromium.org/160598/diff/261/266#newcode20
Line 20: #include "chrome/browser/sync/profile_sync_service.h"
Sort.

http://codereview.chromium.org/160598/diff/261/297
File chrome/browser/views/user_data_page_view.cc (right):

http://codereview.chromium.org/160598/diff/261/297#newcode7
Line 7: #include "chrome/personalization/views/user_data_page_view.h"
eh?

http://codereview.chromium.org/160598/diff/261/297#newcode21
Line 21: #include "chrome/personalization/sync/auth_error_state.h"
eh?

http://codereview.chromium.org/160598/diff/261/298
File chrome/browser/views/user_data_page_view.h (right):

http://codereview.chromium.org/160598/diff/261/298#newcode7
Line 7: #ifndef CHROME_BROWSER_VIEWS_OPTIONS_USER_DATA_PAGE_VIEW_H_
This guard is inconsistent with the file location.

[tim (not reviewing), 2009-08-04 22:39:19]

http://codereview.chromium.org/160598/diff/261/293
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/160598/diff/261/293#newcode43
Line 43: <include file="sync\resources\about_sync.html" flattenhtml="true"
name="IDR_ABOUT_SYNC_HTML" type="BINDATA"/>
On 2009/08/04 22:17:40, nick wrote:
> the tag attributes are ordered differently from the rest of the file.

Done.

http://codereview.chromium.org/160598/diff/261/293#newcode44
Line 44: <include file="sync\resources\gaia_login.html" flattenhtml="true"
name="IDR_GAIA_LOGIN_HTML" type="BINDATA"/>
On 2009/08/04 22:17:40, nick wrote:
> The rest of the file uses a space before the closing "/>".

Done.

http://codereview.chromium.org/160598/diff/261/305
File chrome/browser/dom_ui/new_tab_page_sync_handler.cc (right):

http://codereview.chromium.org/160598/diff/261/305#newcode7
Line 7: #include "chrome/personalization/dom_ui/new_tab_page_sync_handler.h"
On 2009/08/04 22:17:40, nick wrote:
> eh?

Bah.  Had this right the first time, but then had to restart this CL from
scratch and missed this. thanks.
Done.

http://codereview.chromium.org/160598/diff/261/305#newcode18
Line 18: #include "chrome/personalization/personalization_strings.h"
On 2009/08/04 22:17:40, nick wrote:
> eh?

Done.

http://codereview.chromium.org/160598/diff/261/294
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/160598/diff/261/294#newcode47
Line 47: #include "chrome/browser/sync/personalization.h"
On 2009/08/04 22:17:40, nick wrote:
> Sort.

Done.

http://codereview.chromium.org/160598/diff/261/291
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/160598/diff/261/291#newcode21
Line 21: #include "chrome/browser/sync/personalization.h"
On 2009/08/04 22:17:40, nick wrote:
> Sort.

Done.

http://codereview.chromium.org/160598/diff/261/263
File chrome/browser/profile.h (right):

http://codereview.chromium.org/160598/diff/261/263#newcode20
Line 20: #include "chrome/browser/sync/personalization.h"
On 2009/08/04 22:17:40, nick wrote:
> Sort.

Done.

http://codereview.chromium.org/160598/diff/261/268
File chrome/browser/sync/auth_error_state.h (right):

http://codereview.chromium.org/160598/diff/261/268#newcode5
Line 5: #ifndef CHROME_PERSONALIZATION_AUTH_ERROR_STATE_H_
On 2009/08/04 22:17:40, nick wrote:
> CHROME_BROWSER_SYNC_AUTH_ERROR_STATE_H_

Done.

http://codereview.chromium.org/160598/diff/261/289
File chrome/browser/sync/glue/model_associator.h (right):

http://codereview.chromium.org/160598/diff/261/289#newcode25
Line 25: };
On 2009/08/04 22:17:40, nick wrote:
> nit: no semicolon.

Done.

http://codereview.chromium.org/160598/diff/261/289#newcode41
Line 41: // Clears all assocations .
On 2009/08/04 22:17:40, nick wrote:
> nit: extra space.

Done.

http://codereview.chromium.org/160598/diff/261/273
File chrome/browser/sync/personalization.cc (right):

http://codereview.chromium.org/160598/diff/261/273#newcode339
Line 339: #endif
On 2009/08/04 22:17:40, nick wrote:
> #endif  // CHROME_PERSONALIZATION

Done.

http://codereview.chromium.org/160598/diff/261/270
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/160598/diff/261/270#newcode28
Line 28: #include "chrome/browser/sync/engine/syncapi.h"
On 2009/08/04 22:17:40, nick wrote:
> Sort.

Done.

http://codereview.chromium.org/160598/diff/261/266
File chrome/browser/sync/profile_sync_service_unittest.cc (right):

http://codereview.chromium.org/160598/diff/261/266#newcode20
Line 20: #include "chrome/browser/sync/profile_sync_service.h"
On 2009/08/04 22:17:40, nick wrote:
> Sort.

Done.

http://codereview.chromium.org/160598/diff/261/297
File chrome/browser/views/user_data_page_view.cc (right):

http://codereview.chromium.org/160598/diff/261/297#newcode7
Line 7: #include "chrome/personalization/views/user_data_page_view.h"
On 2009/08/04 22:17:40, nick wrote:
> eh?

Done.

http://codereview.chromium.org/160598/diff/261/298
File chrome/browser/views/user_data_page_view.h (right):

http://codereview.chromium.org/160598/diff/261/298#newcode7
Line 7: #ifndef CHROME_BROWSER_VIEWS_OPTIONS_USER_DATA_PAGE_VIEW_H_
On 2009/08/04 22:17:40, nick wrote:
> This guard is inconsistent with the file location.

Good catch.  Moved file to options/

[ncarter (slow), 2009-08-04 22:58:27]

LGTM with sorting fixes discussed online.

This code has been subject to review by Chromium project members (primarily
munjal@, tim@, and myself) during its development, and so here I'm reviewing
mostly the path changes between our development depot and the new locations.  So
the LGTM assumes that you haven't snuck in any diffs to the code from the
development depot.  If there is a possibility of this, I'd like to review those
diffs.

[tim (not reviewing), 2009-08-04 23:49:34]

I haven't snuck-in any diffs except for what was required to satisfy most of
the lint complaints.I figured this would be mostly a rubber-stamp in terms
of reviewing the guts of the code because it has been previously reviewed.
 But I wanted to at least get formal consensus on the folders I created
(like views/sync).

On Tue, Aug 4, 2009 at 3:58 PM, <nick@chromium.org> wrote:

> LGTM with sorting fixes discussed online.
>
> This code has been subject to review by Chromium project members
> (primarily munjal@, tim@, and myself) during its development, and so
> here I'm reviewing mostly the path changes between our development depot
> and the new locations.  So the LGTM assumes that you haven't snuck in
> any diffs to the code from the development depot.  If there is a
> possibility of this, I'd like to review those diffs.
>
>
> http://codereview.chromium.org/160598
>