Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 160542: Rolling back 22317 (Closed)

Created:
11 years, 4 months ago by bradn
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Rolling back 22317 BUG=None TEST=None TBR=tim Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6901 lines) Patch
D chrome/browser/sync/auth_error_state.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/sync/engine/syncapi.h View 1 chunk +0 lines, -709 lines 0 comments Download
D chrome/browser/sync/glue/bookmark_model_worker.h View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/sync/glue/bookmark_model_worker.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/sync/glue/bookmark_model_worker_unittest.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D chrome/browser/sync/glue/http_bridge.h View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/sync/glue/http_bridge.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D chrome/browser/sync/glue/http_bridge_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/sync/glue/model_associator.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/sync/glue/model_associator.cc View 1 chunk +0 lines, -504 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +0 lines, -274 lines 0 comments Download
D chrome/browser/sync/glue/sync_backend_host.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D chrome/browser/sync/personalization.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/sync/personalization.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D chrome/browser/sync/personalization_strings.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/sync/profile_sync_service.h View 1 chunk +0 lines, -368 lines 0 comments Download
D chrome/browser/sync/profile_sync_service.cc View 1 chunk +0 lines, -886 lines 0 comments Download
D chrome/browser/sync/profile_sync_service_unittest.cc View 1 chunk +0 lines, -1272 lines 0 comments Download
D chrome/browser/sync/resources/about_sync.html View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/sync/resources/close.png View Binary file 0 comments Download
D chrome/browser/sync/resources/gaia_login.html View 1 chunk +0 lines, -331 lines 0 comments Download
D chrome/browser/sync/resources/gear.png View Binary file 0 comments Download
D chrome/browser/sync/resources/google_transparent.png View Binary file 0 comments Download
D chrome/browser/sync/resources/merge_and_sync.html View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/sync/resources/merge_and_sync.png View Binary file 0 comments Download
D chrome/browser/sync/resources/new_tab_personalization.html View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/sync/resources/setup_flow.html View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/sync/sync_status_ui_helper.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/sync/sync_status_ui_helper.cc View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
11 years, 4 months ago (2009-08-03 21:55:14 UTC) #1
tim (not reviewing)
11 years, 4 months ago (2009-08-03 22:03:22 UTC) #2
LG
apparently trying to split the .pngs off into their own CL, which needed to
add the sync/ directory, was a bad idea.  it caused all the new children of
sync/ i had locally to go along with it even though they were in another
CL.

On Mon, Aug 3, 2009 at 2:55 PM, <bradnelson@google.com> wrote:

> Reviewers: timsteele,
>
> Description:
> Rolling back 22317
>
> BUG=None
> TEST=None
> TBR=tim
>
>
> Please review this at http://codereview.chromium.org/160542
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  D     chrome/browser/sync/auth_error_state.h
>  D     chrome/browser/sync/engine/syncapi.h
>  D     chrome/browser/sync/glue/bookmark_model_worker.h
>  D     chrome/browser/sync/glue/bookmark_model_worker.cc
>  D     chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
>  D     chrome/browser/sync/glue/http_bridge.h
>  D     chrome/browser/sync/glue/http_bridge.cc
>  D     chrome/browser/sync/glue/http_bridge_unittest.cc
>  D     chrome/browser/sync/glue/model_associator.h
>  D     chrome/browser/sync/glue/model_associator.cc
>  D     chrome/browser/sync/glue/sync_backend_host.h
>  D     chrome/browser/sync/glue/sync_backend_host.cc
>  D     chrome/browser/sync/personalization.h
>  D     chrome/browser/sync/personalization.cc
>  D     chrome/browser/sync/personalization_strings.h
>  D     chrome/browser/sync/profile_sync_service.h
>  D     chrome/browser/sync/profile_sync_service.cc
>  D     chrome/browser/sync/profile_sync_service_unittest.cc
>  D     chrome/browser/sync/resources/about_sync.html
>  D     chrome/browser/sync/resources/close.png
>  D     chrome/browser/sync/resources/gaia_login.html
>  D     chrome/browser/sync/resources/gear.png
>  D     chrome/browser/sync/resources/google_transparent.png
>  D     chrome/browser/sync/resources/merge_and_sync.html
>  D     chrome/browser/sync/resources/merge_and_sync.png
>  D     chrome/browser/sync/resources/new_tab_personalization.html
>  D     chrome/browser/sync/resources/setup_flow.html
>  D     chrome/browser/sync/sync_status_ui_helper.h
>  D     chrome/browser/sync/sync_status_ui_helper.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698