update engine: 32- and 64-bit compile

update engine: 32- and 64-bit compile

[Daniel Erat, 2010-04-14 13:58:45]

http://codereview.chromium.org/1599029/diff/1/4
File src/platform/update_engine/bzip.cc (right):

http://codereview.chromium.org/1599029/diff/1/4#newcode23
src/platform/update_engine/bzip.cc:23: uint32* out_length,
It's probably better to use uint32_t, etc. from stdint.h here.  I think that the
non-_t typedefs are just being pulled in from the logging library.

http://codereview.chromium.org/1599029/diff/1/4#newcode82
src/platform/update_engine/bzip.cc:82: return
BzipData<BzipBuffToBuffDecompress>(&in[0], static_cast<int32>(in.size()), out);
wrap long line

http://codereview.chromium.org/1599029/diff/1/12
File src/platform/update_engine/subprocess.cc (right):

http://codereview.chromium.org/1599029/diff/1/12#newcode51
src/platform/update_engine/subprocess.cc:51: scoped_array<char *> argp(new
char*[2]);
be consistent about where you put spaces in pointer types (this file has both
versions)

http://codereview.chromium.org/1599029/diff/1/12#newcode55
src/platform/update_engine/subprocess.cc:55: argp[0] =
strdup(StringPrintf("%s=%s", kLdLibraryPathKey,
getenv(kLdLibraryPathKey)).c_str());
wrap long line

http://codereview.chromium.org/1599029/diff/1/13
File src/platform/update_engine/test_http_server.cc (right):

http://codereview.chromium.org/1599029/diff/1/13#newcode102
src/platform/update_engine/test_http_server.cc:102: if (sizeof(long) ==
sizeof(off_t))
use inttypes.h instead (see http://en.wikipedia.org/wiki/Printf)

http://codereview.chromium.org/1599029/diff/1/15
File src/platform/update_engine/update_check_action.cc (right):

http://codereview.chromium.org/1599029/diff/1/15#newcode177
src/platform/update_engine/update_check_action.cc:177: if (sizeof(long) == 8) {
here too

[adlr, 2010-04-14 19:11:21]

http://codereview.chromium.org/1599029/diff/1/4
File src/platform/update_engine/bzip.cc (right):

http://codereview.chromium.org/1599029/diff/1/4#newcode23
src/platform/update_engine/bzip.cc:23: uint32* out_length,
On 2010/04/14 13:58:46, Daniel Erat wrote:
> It's probably better to use uint32_t, etc. from stdint.h here.  I think that
the
> non-_t typedefs are just being pulled in from the logging library.

Done.

http://codereview.chromium.org/1599029/diff/1/4#newcode82
src/platform/update_engine/bzip.cc:82: return
BzipData<BzipBuffToBuffDecompress>(&in[0], static_cast<int32>(in.size()), out);
On 2010/04/14 13:58:46, Daniel Erat wrote:
> wrap long line

Done.

http://codereview.chromium.org/1599029/diff/1/12
File src/platform/update_engine/subprocess.cc (right):

http://codereview.chromium.org/1599029/diff/1/12#newcode51
src/platform/update_engine/subprocess.cc:51: scoped_array<char *> argp(new
char*[2]);
On 2010/04/14 13:58:46, Daniel Erat wrote:
> be consistent about where you put spaces in pointer types (this file has both
> versions)

Done.

http://codereview.chromium.org/1599029/diff/1/12#newcode55
src/platform/update_engine/subprocess.cc:55: argp[0] =
strdup(StringPrintf("%s=%s", kLdLibraryPathKey,
getenv(kLdLibraryPathKey)).c_str());
On 2010/04/14 13:58:46, Daniel Erat wrote:
> wrap long line

Done.

http://codereview.chromium.org/1599029/diff/1/13
File src/platform/update_engine/test_http_server.cc (right):

http://codereview.chromium.org/1599029/diff/1/13#newcode102
src/platform/update_engine/test_http_server.cc:102: if (sizeof(long) ==
sizeof(off_t))
On 2010/04/14 13:58:46, Daniel Erat wrote:
> use inttypes.h instead (see http://en.wikipedia.org/wiki/Printf)

Done.

http://codereview.chromium.org/1599029/diff/1/15
File src/platform/update_engine/update_check_action.cc (right):

http://codereview.chromium.org/1599029/diff/1/15#newcode177
src/platform/update_engine/update_check_action.cc:177: if (sizeof(long) == 8) {
On 2010/04/14 13:58:46, Daniel Erat wrote:
> here too

Done.

[Daniel Erat, 2010-04-15 00:55:47]

LGTM

http://codereview.chromium.org/1599029/diff/8001/6007
File src/platform/update_engine/extent_writer.h (right):

http://codereview.chromium.org/1599029/diff/8001/6007#newcode32
src/platform/update_engine/extent_writer.h:32: uint32 block_size) = 0;
switch this to uint32_t

http://codereview.chromium.org/1599029/diff/8001/6007#newcode60
src/platform/update_engine/extent_writer.h:60: bool Init(int fd, const
std::vector<Extent>& extents, uint32 block_size) {
this too

http://codereview.chromium.org/1599029/diff/8001/6007#newcode95
src/platform/update_engine/extent_writer.h:95: bool Init(int fd, const
std::vector<Extent>& extents, uint32 block_size) {
and this

http://codereview.chromium.org/1599029/diff/8001/6008
File src/platform/update_engine/gen_coverage_html.sh (right):

http://codereview.chromium.org/1599029/diff/8001/6008#newcode14
src/platform/update_engine/gen_coverage_html.sh:14: #./update_engine_unittests
--gtest_filter='ZipTest*.*'
did you mean to leave this in?  it's commented out.

http://codereview.chromium.org/1599029/diff/8001/6017
File src/platform/update_engine/utils.cc (right):

http://codereview.chromium.org/1599029/diff/8001/6017#newcode83
src/platform/update_engine/utils.cc:83: for (uint32 i = 0; i < length; i +=
bytes_per_line) {
uint32_t