Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: src/platform/update_engine/update_check_action_unittest.cc

Issue 1599029: update engine: 32- and 64-bit compile (Closed)
Patch Set: int32->int32_t, PRIi64, 80 cols for review Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/update_engine/update_check_action_unittest.cc
diff --git a/src/platform/update_engine/update_check_action_unittest.cc b/src/platform/update_engine/update_check_action_unittest.cc
index 417a47e3c6bed738e3fa48d68005a0a37adc98c0..c57e2cd0646fb4bfd730ec126907adc4ce3e9212 100644
--- a/src/platform/update_engine/update_check_action_unittest.cc
+++ b/src/platform/update_engine/update_check_action_unittest.cc
@@ -93,6 +93,7 @@ class ActionTraits<OutputObjectCollectorAction> {
class OutputObjectCollectorAction : public Action<OutputObjectCollectorAction> {
public:
+ OutputObjectCollectorAction() : has_input_object_(false) {}
void PerformAction() {
// copy input object
has_input_object_ = HasInputObject();
@@ -249,7 +250,7 @@ TEST(UpdateCheckActionTest, InvalidXmlTest) {
"en-US",
"unittest_track");
UpdateCheckResponse response;
- ASSERT_TRUE(
+ ASSERT_FALSE(
TestUpdateCheckAction(params,
"invalid xml>",
false,
@@ -269,7 +270,7 @@ TEST(UpdateCheckActionTest, MissingStatusTest) {
"en-US",
"unittest_track");
UpdateCheckResponse response;
- ASSERT_TRUE(TestUpdateCheckAction(
+ ASSERT_FALSE(TestUpdateCheckAction(
params,
"<?xml version=\"1.0\" encoding=\"UTF-8\"?><gupdate "
"xmlns=\"http://www.google.com/update2/response\" protocol=\"2.0\"><app "
@@ -292,7 +293,7 @@ TEST(UpdateCheckActionTest, InvalidStatusTest) {
"en-US",
"unittest_track");
UpdateCheckResponse response;
- ASSERT_TRUE(TestUpdateCheckAction(
+ ASSERT_FALSE(TestUpdateCheckAction(
params,
"<?xml version=\"1.0\" encoding=\"UTF-8\"?><gupdate "
"xmlns=\"http://www.google.com/update2/response\" protocol=\"2.0\"><app "
@@ -315,7 +316,7 @@ TEST(UpdateCheckActionTest, MissingNodesetTest) {
"en-US",
"unittest_track");
UpdateCheckResponse response;
- ASSERT_TRUE(TestUpdateCheckAction(
+ ASSERT_FALSE(TestUpdateCheckAction(
params,
"<?xml version=\"1.0\" encoding=\"UTF-8\"?><gupdate "
"xmlns=\"http://www.google.com/update2/response\" protocol=\"2.0\"><app "
@@ -435,7 +436,7 @@ TEST(UpdateCheckActionTest, XmlEncodeTest) {
"en-US",
"unittest_track");
UpdateCheckResponse response;
- ASSERT_TRUE(
+ ASSERT_FALSE(
TestUpdateCheckAction(params,
"invalid xml>",
false,

Powered by Google App Engine
This is Rietveld 408576698