src/platform/update_engine/gzip.cc - Issue 1599029: update engine: 32- and 64-bit compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/update_engine/gzip.cc

Issue 1599029: update engine: 32- and 64-bit compile (Closed)

Patch Set: int32->int32_t, PRIi64, 80 cols for review Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform/update_engine/gzip.cc

diff --git a/src/platform/update_engine/gzip.cc b/src/platform/update_engine/gzip.cc

index 96437248a8934c5bd15d6355a5558773aa13700d..5fbd043eaa6a17d082876588e86d60a5fc0e5c69 100644

--- a/src/platform/update_engine/gzip.cc

+++ b/src/platform/update_engine/gzip.cc

@@ -93,7 +93,7 @@ bool GzipCompressData(const char* const in, const size_t in_size,

Z_DEFAULT_STRATEGY) == Z_OK);

// guess that output will be roughly half the input size

- *out_size = max(1U, in_size / 2);

+ *out_size = max(static_cast<size_t>(1), in_size / 2);

*out = reinterpret_cast<char*>(malloc(*out_size));

TEST_AND_RETURN_FALSE(*out);