Use Objects instead of Values as only Objects may refer to implementation.

Use Objects instead of Values as only Objects may refer to implementation.

[Anton Muhin, 2009-07-17 13:00:44]

Mads, if you like this change, I'd appreciate if you could land it as well.

yours,
anton.

On Fri, Jul 17, 2009 at 4:58 PM, <antonm@chromium.org> wrote:
> Reviewers: Mads Ager,
>
> Description:
> Use Objects instead of Values as only Objects may refer to
> implementation.
>
> Please review this at http://codereview.chromium.org/159003
>
> Affected files:
> =A0M webkit/glue/webdevtoolsclient_impl.cc
>
>
> Index: webkit/glue/webdevtoolsclient_impl.cc
> diff --git a/webkit/glue/webdevtoolsclient_impl.cc
> b/webkit/glue/webdevtoolsclient_impl.cc
> index
> 5bb2883711259dc5763f790977cc870b9e734f0f..acc920e05b35c30b819fc46453a17eb=
f9efa02c8
> 100644
> --- a/webkit/glue/webdevtoolsclient_impl.cc
> +++ b/webkit/glue/webdevtoolsclient_impl.cc
> @@ -262,7 +262,7 @@ v8::Handle<v8::Value>
> WebDevToolsClientImpl::JsAddSourceToFrame(
> =A0 if (source_string.isEmpty() || exception_catcher.HasCaught()) {
> =A0 =A0 return v8::Undefined();
> =A0 }
> - =A0Node* node =3D V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
> + =A0Node* node =3D
> V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(=
args[2]));
> =A0 if (!node || !node->attached()) {
> =A0 =A0 return v8::Undefined();
> =A0 }
> @@ -281,7 +281,7 @@ v8::Handle<v8::Value>
> WebDevToolsClientImpl::JsAddResourceSourceToFrame(
> =A0 if (mime_type.isEmpty()) {
> =A0 =A0 return v8::Undefined();
> =A0 }
> - =A0Node* node =3D V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
> + =A0Node* node =3D
> V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(=
args[2]));
> =A0 WebDevToolsClientImpl* client =3D static_cast<WebDevToolsClientImpl*>=
(
> =A0 =A0 =A0 v8::External::Cast(*args.Data())->Value());
> =A0 client->AddResourceSourceToFrame(resource_id, mime_type, node);
>
>
>

[Mads Ager (chromium), 2009-07-17 17:03:57]

LGTM except that the lines are too long.  I'll fix that when I land the patch.

[Anton Muhin, 2009-07-20 14:55:48]

Tnx a lot, Mads, and sorry for too long line.

yours,
anton.

On Fri, Jul 17, 2009 at 9:03 PM, <ager@chromium.org> wrote:
> LGTM except that the lines are too long. =A0I'll fix that when I land the
> patch.
>
> http://codereview.chromium.org/159003
>