Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: webkit/glue/webdevtoolsclient_impl.cc

Issue 159003: Use Objects instead of Values as only Objects may refer to implementation. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webdevtoolsclient_impl.cc
diff --git a/webkit/glue/webdevtoolsclient_impl.cc b/webkit/glue/webdevtoolsclient_impl.cc
index 5bb2883711259dc5763f790977cc870b9e734f0f..acc920e05b35c30b819fc46453a17ebf9efa02c8 100644
--- a/webkit/glue/webdevtoolsclient_impl.cc
+++ b/webkit/glue/webdevtoolsclient_impl.cc
@@ -262,7 +262,7 @@ v8::Handle<v8::Value> WebDevToolsClientImpl::JsAddSourceToFrame(
if (source_string.isEmpty() || exception_catcher.HasCaught()) {
return v8::Undefined();
}
- Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
+ Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(args[2]));
if (!node || !node->attached()) {
return v8::Undefined();
}
@@ -281,7 +281,7 @@ v8::Handle<v8::Value> WebDevToolsClientImpl::JsAddResourceSourceToFrame(
if (mime_type.isEmpty()) {
return v8::Undefined();
}
- Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
+ Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(args[2]));
WebDevToolsClientImpl* client = static_cast<WebDevToolsClientImpl*>(
v8::External::Cast(*args.Data())->Value());
client->AddResourceSourceToFrame(resource_id, mime_type, node);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698