Issue 1576026: Add support for bkpt instruction...

Issue 1576026: Add support for bkpt instruction... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add support for bkpt instruction The bkpt instruction is now supported by both the disassembler and the simulator. In the simulator it breaks to the native debugger if any like int3 on Intel. Moved the handling of the miscellaneous instructions to a separate part. Committed: http://code.google.com/p/v8/source/detail?r=4360

Patch Set 1 #

Total comments: 10

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -65 lines)			Patch
M	src/arm/constants-arm.h	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	src/arm/disasm-arm.cc	View	4 chunks	+38 lines, -19 lines	6 comments	Download
M	src/arm/simulator-arm.cc	View	3 chunks	+46 lines, -36 lines	4 comments	Download
M	test/cctest/test-disasm-arm.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1576026/diff/1/5 File src/arm/disasm-arm.cc (right): http://codereview.chromium.org/1576026/diff/1/5#newcode661 src/arm/disasm-arm.cc:661: } else if ((type == 0) && instr->IsMiscType0()) ...

10 years, 8 months ago (2010-04-08 12:56:30 UTC) #2

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-08 13:29:06 UTC) #3

http://codereview.chromium.org/1576026/diff/1/5
File src/arm/disasm-arm.cc (right):

http://codereview.chromium.org/1576026/diff/1/5#newcode661
src/arm/disasm-arm.cc:661: } else if ((type == 0) && instr->IsMiscType0()) {
On 2010/04/08 12:56:30, Erik Corry wrote:
> This is a little strange to me, but if it matches the manual organization then
> I'm fine with it.

Section A5.2 in ARM® Architecture Reference Manual ARM®v7-A and ARM®v7-R
edition.

http://codereview.chromium.org/1576026/diff/1/5#newcode735
src/arm/disasm-arm.cc:735: Unknown(instr);  // not used by V8
On 2010/04/08 12:56:30, Erik Corry wrote:
> UNREACHABLE();  // Handled by IsMiscType0 code above.

Done.

http://codereview.chromium.org/1576026/diff/1/5#newcode751
src/arm/disasm-arm.cc:751: Unknown(instr);  // not used by V8
On 2010/04/08 12:56:30, Erik Corry wrote:
> And here.

Done.

http://codereview.chromium.org/1576026/diff/1/4
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/1576026/diff/1/4#newcode1629
src/arm/simulator-arm.cc:1629: UNIMPLEMENTED();
On 2010/04/08 12:56:30, Erik Corry wrote:
> UNREACHABLE

Done.

http://codereview.chromium.org/1576026/diff/1/4#newcode1657
src/arm/simulator-arm.cc:1657: UNIMPLEMENTED();
On 2010/04/08 12:56:30, Erik Corry wrote:
> &here
> 

Done.

Expand Messages | Collapse Messages