Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6271)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)
Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_view_host.cc
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc
index 35bfec58fff9d2a6bef2222654d48dc9489b794c..47debf786a65071bb0afb47fbd29406cb399a313 100644
--- a/chrome/browser/renderer_host/render_view_host.cc
+++ b/chrome/browser/renderer_host/render_view_host.cc
@@ -787,10 +787,10 @@ void RenderViewHost::OnMessageReceived(const IPC::Message& msg) {
OnActivateDevToolsWindow);
IPC_MESSAGE_HANDLER(ViewHostMsg_CloseDevToolsWindow,
OnCloseDevToolsWindow);
- IPC_MESSAGE_HANDLER(ViewHostMsg_DockDevToolsWindow,
- OnDockDevToolsWindow);
- IPC_MESSAGE_HANDLER(ViewHostMsg_UndockDevToolsWindow,
- OnUndockDevToolsWindow);
+ IPC_MESSAGE_HANDLER(ViewHostMsg_RequestDockDevToolsWindow,
+ OnRequestDockDevToolsWindow);
+ IPC_MESSAGE_HANDLER(ViewHostMsg_RequestUndockDevToolsWindow,
+ OnRequestUndockDevToolsWindow);
IPC_MESSAGE_HANDLER(ViewHostMsg_DevToolsRuntimeFeatureStateChanged,
OnDevToolsRuntimeFeatureStateChanged);
IPC_MESSAGE_HANDLER(ViewHostMsg_UserMetricsRecordAction,
@@ -1445,12 +1445,12 @@ void RenderViewHost::OnCloseDevToolsWindow() {
DevToolsManager::GetInstance()->CloseWindow(this);
}
-void RenderViewHost::OnDockDevToolsWindow() {
- DevToolsManager::GetInstance()->DockWindow(this);
+void RenderViewHost::OnRequestDockDevToolsWindow() {
+ DevToolsManager::GetInstance()->RequestDockWindow(this);
}
-void RenderViewHost::OnUndockDevToolsWindow() {
- DevToolsManager::GetInstance()->UndockWindow(this);
+void RenderViewHost::OnRequestUndockDevToolsWindow() {
+ DevToolsManager::GetInstance()->RequestUndockWindow(this);
}
void RenderViewHost::OnDevToolsRuntimeFeatureStateChanged(
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698