Fix docking behaviour for devtools windows that don't have an associated browser window

chrome/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 769 matching lines @@
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidPrintPage, DidPrintPage)
     IPC_MESSAGE_HANDLER(ViewHostMsg_AddMessageToConsole, OnAddMessageToConsole)
     IPC_MESSAGE_HANDLER(ViewHostMsg_ForwardToDevToolsAgent,
                         OnForwardToDevToolsAgent);
     IPC_MESSAGE_HANDLER(ViewHostMsg_ForwardToDevToolsClient,
                         OnForwardToDevToolsClient);
     IPC_MESSAGE_HANDLER(ViewHostMsg_ActivateDevToolsWindow,
                         OnActivateDevToolsWindow);
     IPC_MESSAGE_HANDLER(ViewHostMsg_CloseDevToolsWindow,
                         OnCloseDevToolsWindow);
-    IPC_MESSAGE_HANDLER(ViewHostMsg_DockDevToolsWindow,
-                        OnDockDevToolsWindow);
-    IPC_MESSAGE_HANDLER(ViewHostMsg_UndockDevToolsWindow,
-                        OnUndockDevToolsWindow);
+    IPC_MESSAGE_HANDLER(ViewHostMsg_RequestDockDevToolsWindow,
+                        OnRequestDockDevToolsWindow);
+    IPC_MESSAGE_HANDLER(ViewHostMsg_RequestUndockDevToolsWindow,
+                        OnRequestUndockDevToolsWindow);
     IPC_MESSAGE_HANDLER(ViewHostMsg_DevToolsRuntimeFeatureStateChanged,
                         OnDevToolsRuntimeFeatureStateChanged);
     IPC_MESSAGE_HANDLER(ViewHostMsg_UserMetricsRecordAction,
                         OnUserMetricsRecordAction)
     IPC_MESSAGE_HANDLER(ViewHostMsg_MissingPluginStatus, OnMissingPluginStatus);
     IPC_MESSAGE_HANDLER(ViewHostMsg_CrashedPlugin, OnCrashedPlugin);
     IPC_MESSAGE_HANDLER(ViewHostMsg_SendCurrentPageAllSavableResourceLinks,
                         OnReceivedSavableResourceLinksForCurrentPage);
     IPC_MESSAGE_HANDLER(ViewHostMsg_SendSerializedHtmlData,
                         OnReceivedSerializedHtmlData);
@@ skipping 634 matching lines @@
 }
 
 void RenderViewHost::OnActivateDevToolsWindow() {
   DevToolsManager::GetInstance()->ActivateWindow(this);
 }
 
 void RenderViewHost::OnCloseDevToolsWindow() {
   DevToolsManager::GetInstance()->CloseWindow(this);
 }
 
-void RenderViewHost::OnDockDevToolsWindow() {
-  DevToolsManager::GetInstance()->DockWindow(this);
+void RenderViewHost::OnRequestDockDevToolsWindow() {
+  DevToolsManager::GetInstance()->RequestDockWindow(this);
 }
 
-void RenderViewHost::OnUndockDevToolsWindow() {
-  DevToolsManager::GetInstance()->UndockWindow(this);
+void RenderViewHost::OnRequestUndockDevToolsWindow() {
+  DevToolsManager::GetInstance()->RequestUndockWindow(this);
 }
 
 void RenderViewHost::OnDevToolsRuntimeFeatureStateChanged(
     const std::string& feature,
     bool enabled) {
   DevToolsManager::GetInstance()->
       RuntimeFeatureStateChanged(this, feature, enabled);
 }
 
 void RenderViewHost::OnUserMetricsRecordAction(const std::string& action) {
@@ skipping 389 matching lines @@
   integration_delegate->OnPageTranslated(page_id, original_lang,
                                          translated_lang, error_type);
 }
 
 void RenderViewHost::OnContentBlocked(ContentSettingsType type) {
   RenderViewHostDelegate::Resource* resource_delegate =
       delegate_->GetResourceDelegate();
   if (resource_delegate)
     resource_delegate->OnContentBlocked(type);
 }