chrome/browser/renderer_host/render_view_host.h - Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_view_host.h

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)

Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/render_view_host.h

diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h

index 3f8586d26a335cd9be0d62259bdf8f7d968fb13c..e35a707e886a2ac9a836f49c98896d63c5385da2 100644

--- a/chrome/browser/renderer_host/render_view_host.h

+++ b/chrome/browser/renderer_host/render_view_host.h

@@ -563,8 +563,8 @@ class RenderViewHost : public RenderWidgetHost {

void OnForwardToDevToolsClient(const IPC::Message& message);

void OnActivateDevToolsWindow();

void OnCloseDevToolsWindow();

- void OnDockDevToolsWindow();

- void OnUndockDevToolsWindow();

+ void OnRequestDockDevToolsWindow();

+ void OnRequestUndockDevToolsWindow();

void OnDevToolsRuntimeFeatureStateChanged(const std::string& feature,

bool enabled);