chrome/browser/metrics/metrics_log.cc - Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations. (Closed)

Patch Set: comments Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index 03dd92559759ee121f2532b477ff26c2efab430b..baa7ec33482df35994159329529264b9ee499f4d 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -15,6 +15,7 @@

#include "base/sys_info.h"

#include "base/utf_string_conversions.h"

#include "base/third_party/nspr/prtime.h"

+#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/autocomplete/autocomplete.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/pref_service.h"

@@ -302,7 +303,7 @@ void MetricsLog::EndElement() {

// static

std::string MetricsLog::GetVersionString() {

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ chrome_app::GetChromeVersionInfo());

if (version_info.get()) {

std::string version = WideToUTF8(version_info->product_version());

if (!version_extension_.empty())