chrome/browser/safe_browsing/protocol_manager.cc - Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations. (Closed)

Patch Set: comments Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/protocol_manager.cc

diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc

index 4fe02cec3c4d2ff984db3827d97f3cc53c261d2d..0a293c84e97b44cdf0850ecc3a579ba50596bb0b 100644

--- a/chrome/browser/safe_browsing/protocol_manager.cc

+++ b/chrome/browser/safe_browsing/protocol_manager.cc

@@ -14,6 +14,7 @@

#include "base/string_util.h"

#include "base/task.h"

#include "base/timer.h"

+#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/net/url_request_context_getter.h"

#include "chrome/browser/profile.h"

@@ -87,7 +88,7 @@ SafeBrowsingProtocolManager::SafeBrowsingProtocolManager(

next_update_sec_ = base::RandInt(60, kSbTimerStartIntervalSec);

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ chrome_app::GetChromeVersionInfo());

if (!version_info.get())

version_ = "0.1";

else

« no previous file with comments | « chrome/browser/metrics/metrics_log.cc ('k') | chrome/browser/sync/glue/sync_backend_host.cc » ('j') | no next file with comments »