chrome/browser/memory_details_win.cc - Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_win.cc

Issue 1560027: Refactor FileVersionInfo into an interface with platform implementations. (Closed)

Patch Set: comments Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory_details_win.cc

diff --git a/chrome/browser/memory_details_win.cc b/chrome/browser/memory_details_win.cc

index c7fb40bc4029c9cda36b4aabe38681d1307dd5dc..56ae42453d5f87c15db84461044fe49d9d90691d 100644

--- a/chrome/browser/memory_details_win.cc

+++ b/chrome/browser/memory_details_win.cc

@@ -8,6 +8,7 @@

#include "app/l10n_util.h"

#include "base/file_version_info.h"

#include "base/string_util.h"

+#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/child_process_host.h"

#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/renderer_host/backing_store_manager.h"

@@ -121,7 +122,7 @@ void MemoryDetails::CollectProcessData(

TCHAR name[MAX_PATH];

if (index2 == CHROME_BROWSER || index2 == CHROME_NACL_PROCESS) {

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ chrome_app::GetChromeVersionInfo());

if (version_info != NULL)

info.version = version_info->file_version();

// Check if this is one of the child processes whose data we collected

« no previous file with comments | « chrome/browser/memory_details_mac.cc ('k') | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »