Fix the URL status bubble overlapping the Mac download shelf

Fix for the URL status bubble overlapping the download shelf.

BUG=14662
(http://crbug.com/14662)
TEST=Download something so that the shelf is visible and make sure
     that hovering over links on the page produce a status bubble
     above the download shelf.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21185

[pink (ping after 24hrs), 2009-07-17 20:57:19]

http://codereview.chromium.org/155706/diff/1005/1009
File chrome/browser/cocoa/download_shelf_controller.h (right):

http://codereview.chromium.org/155706/diff/1005/1009#newcode60
Line 60: - (int)height;
cocoa uses floats for dimensions.

http://codereview.chromium.org/155706/diff/1005/1011
File chrome/browser/cocoa/status_bubble_mac.h (right):

http://codereview.chromium.org/155706/diff/1005/1011#newcode20
Line 20: StatusBubbleMac(NSWindow* parent, BrowserWindowController* controller);
the status bubble really shouldn't know about the BWC. If it has to ask someone
for info, it should do so via a delegate api or a protocol that the BWC just
happens to implement.

http://codereview.chromium.org/155706/diff/1005/1007
File chrome/browser/cocoa/status_bubble_mac.mm (right):

http://codereview.chromium.org/155706/diff/1005/1007#newcode195
Line 195: window_frame.origin.y += [[parent_controller_ downloadShelf] height];
maybe instead of asking if the download shelf is visible, ask the "delegate" if
there's an offset that should be applied to its position. That way it doesn't
have to know about either the download shelf or the BWC. Fewer direct
dependencies = better.

[Nico, 2009-07-17 20:57:23]

http://codereview.chromium.org/155706/diff/1005/1009
File chrome/browser/cocoa/download_shelf_controller.h (right):

http://codereview.chromium.org/155706/diff/1005/1009#newcode42
Line 42: // Not currently hooked up.
It's called from download_shelf_mac as far as I remember.

[Paul Godavari, 2009-07-17 22:44:18]

Updated:
- made offset a float
- added a delegate to StatusBubbleMac

[pink (ping after 24hrs), 2009-07-21 14:09:08]

LGTM

http://codereview.chromium.org/155706/diff/39/1040
File chrome/browser/cocoa/status_bubble_mac.h (right):

http://codereview.chromium.org/155706/diff/39/1040#newcode67
Line 67: - (float)verticalOffset;
might want to have the name somehow reflect that this is for the status bubble?
At its impl point in BWC, it is a bit out of context. I know there's a comment
that says it's for the status bubble, but making it a little more self
documenting would be helpful, IMHO.