Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 155706: Fix the URL status bubble overlapping the Mac download shelf (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.h ('k') | chrome/browser/cocoa/download_shelf_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_controller.mm
===================================================================
--- chrome/browser/cocoa/browser_window_controller.mm (revision 21184)
+++ chrome/browser/cocoa/browser_window_controller.mm (working copy)
@@ -204,7 +204,7 @@
object:[self tabContentArea]];
// Create the bridge for the status bubble.
- statusBubble_.reset(new StatusBubbleMac([self window]));
+ statusBubble_.reset(new StatusBubbleMac([self window], self));
#if 0
// Move all buttons down two pixels for visual balance.
@@ -440,6 +440,18 @@
browser_->ExecuteCommand(command);
}
+// StatusBubble delegate method: tell the status bubble how far above the bottom
+// of the window it should position itself.
+- (float)verticalOffsetForStatusBubble {
+ float offset = 0.0;
+
+ // Don't create a download shelf if there isn't one.
+ if (downloadShelfController_.get() && [[self downloadShelf] isVisible])
+ offset += [[self downloadShelf] height];
+
+ return offset;
+}
+
- (LocationBar*)locationBar {
return [toolbarController_ locationBar];
}
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.h ('k') | chrome/browser/cocoa/download_shelf_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698