Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3007)

Unified Diff: chrome/browser/cocoa/download_shelf_controller.mm

Issue 155706: Fix the URL status bubble overlapping the Mac download shelf (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/download_shelf_controller.h ('k') | chrome/browser/cocoa/download_shelf_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/download_shelf_controller.mm
===================================================================
--- chrome/browser/cocoa/download_shelf_controller.mm (revision 21184)
+++ chrome/browser/cocoa/download_shelf_controller.mm (working copy)
@@ -177,9 +177,19 @@
}
- (void)hide:(id)sender {
- [self showDownloadShelf:NO];
+ // If |sender| isn't nil, then we're being closed from the UI by the user and
+ // we need to tell our shelf implementation to close. Otherwise, we're being
+ // closed programmatically by our shelf implementation.
+ if (sender)
+ bridge_->Close();
+ else
+ [self showDownloadShelf:NO];
}
+- (float)height {
+ return shelfHeight_;
+}
+
- (void)addDownloadItem:(BaseDownloadItemModel*)model {
// TODO(thakis): we need to delete these at some point. There's no explicit
// mass delete on windows, figure out where they do it.
« no previous file with comments | « chrome/browser/cocoa/download_shelf_controller.h ('k') | chrome/browser/cocoa/download_shelf_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698