Use manually constructed IPv6 socket addresses for tests, rather than system ...

Use manually constructed IPv6 socket addresses for tests, rather than system created ones.

The advantage is that GURL's parsing of IPv6 addresses works on all systems, whereas getaddrinfo(ipv6_literal) only succeeds on IPv6 enabled systems.

This allows the tests to run consistently on all systems, including our own WinXP buildbots (which do not support IPv6).

BUG=http://crbug.com/16452
TEST=[net_unittests] SOCKS5ClientSocketTest.IPv6Domain, SOCKSClientSocketTest.SOCKS4AIfDomainInIPv6


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21053

[eroman, 2009-07-16 03:32:44]

@arindam: please review the changes to the SOCKS unit tests.
@willchan: please review everything else.

[willchan no longer on Chromium, 2009-07-17 23:06:17]

lgtm

http://codereview.chromium.org/155618/diff/29/1034
File net/base/address_list.h (right):

http://codereview.chromium.org/155618/diff/29/1034#newcode48
Line 48: static AddressList CreateIPv6Address(unsigned char data[16]);
I would get rid of the 16 because the compiler will ignore it.  You could pass
in a char* and it'd accept it.  If you indeed want to force the compiler to only
accept an array, you should use (unsigned char (&) data[16]) as your parameter.

http://codereview.chromium.org/155618/diff/29/1031
File net/base/mock_host_resolver.h (right):

http://codereview.chromium.org/155618/diff/29/1031#newcode106
Line 106: // Fills |addrlist| with a socket address for |host| which should be
an
Any reason to put this in the .h file?  It seems like an implementation detail;
how about putting it in an anonymous namespace in the .cc file?

[eroman, 2009-07-18 07:31:56]

http://codereview.chromium.org/155618/diff/29/1034
File net/base/address_list.h (right):

http://codereview.chromium.org/155618/diff/29/1034#newcode48
Line 48: static AddressList CreateIPv6Address(unsigned char data[16]);
On 2009/07/17 23:06:17, willchan wrote:
> I would get rid of the 16 because the compiler will ignore it.  You could pass
> in a char* and it'd accept it.  If you indeed want to force the compiler to
only
> accept an array, you should use (unsigned char (&) data[16]) as your
parameter.

I would rather leave the [16] -- I find it convenient as a form of
documentation.

http://codereview.chromium.org/155618/diff/29/1031
File net/base/mock_host_resolver.h (right):

http://codereview.chromium.org/155618/diff/29/1031#newcode106
Line 106: // Fills |addrlist| with a socket address for |host| which should be
an
On 2009/07/17 23:06:17, willchan wrote:
> Any reason to put this in the .h file?  It seems like an implementation
detail;
> how about putting it in an anonymous namespace in the .cc file?

Done.