Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: net/base/host_resolver_impl_unittest.cc

Issue 155618: Use manually constructed IPv6 socket addresses for tests, rather than system ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/address_list.cc ('k') | net/base/mock_host_resolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl_unittest.cc
===================================================================
--- net/base/host_resolver_impl_unittest.cc (revision 21052)
+++ net/base/host_resolver_impl_unittest.cc (working copy)
@@ -318,7 +318,12 @@
}
}
-TEST_F(HostResolverImplTest, EmptyHost) {
+// TODO(eroman): This test is disabled because it is bogus. It used to pass
+// solely because of a bug in the RuleBasedHostMapper -- (empty replacements
+// would map to a failure). However when using the actual host resolver
+// (getaddrinfo), this is not necessarily the case. On windows getaddrinfo("")
+// gives you the address of your machine.
+TEST_F(HostResolverImplTest, DISABLED_EmptyHost) {
scoped_refptr<RuleBasedHostResolverProc> resolver_proc =
new RuleBasedHostResolverProc(NULL);
resolver_proc->AllowDirectLookup("*");
« no previous file with comments | « net/base/address_list.cc ('k') | net/base/mock_host_resolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698