Issue 155163: Downstream the partially upstreamed NPV8 files with fixes for errors introduced in upstreaming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155163: Downstream the partially upstreamed NPV8 files with fixes for errors introduced in upstreaming. (Closed)

Created:
11 years, 5 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
levin, Nate Chapin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Downstream the partially upstreamed NPV8 files with fixes for errors introduced in upstreaming. This should not change any layout tests expectations.

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -294 lines)			Patch
M	webkit/port/bindings/v8/NPV8Object.h	View		3 chunks	+35 lines, -11 lines	0 comments	Download
M	webkit/port/bindings/v8/NPV8Object.cpp	View	1	8 chunks	+193 lines, -215 lines	0 comments	Download
M	webkit/port/bindings/v8/V8NPUtils.h	View		1 chunk	+36 lines, -17 lines	0 comments	Download
M	webkit/port/bindings/v8/V8NPUtils.cpp	View		3 chunks	+56 lines, -51 lines	0 comments	Download

Total messages: 2 (0 generated)

awong

I kinda verified this passed all the layout tests, but need to ask someone with ...

11 years, 5 months ago (2009-07-07 20:48:26 UTC) #1

Nate Chapin

11 years, 5 months ago (2009-07-09 17:27:08 UTC) #2

LGTM.

The layout tests looked fine with this patch on my XP box.  Thanks!