Remove any double qoutes from defines, fed into bindings generator....

Remove any double qoutes from defines, fed into bindings generator.

R=mark
BUG=15904
TEST=no more weird errors when generating bindings



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19952

[Ben Laurie, 2009-07-06 16:11:20]

Otherwise LGTM.

http://codereview.chromium.org/155089/diff/1/2
File webkit/build/rule_binding.py (right):

http://codereview.chromium.org/155089/diff/1/2#newcode77
Line 77: # the options will have meaningful double qoutes.
To defend against the possibility of a define that defines to a string (and
hence has meaningful double quotes), how about asserting that there's no
instances of '\"' in the options?

[Mark Mentovai, 2009-07-06 16:12:34]

I can really only give this a temporary to-fix-the-build LGTM.  It's not
strictly correct.

We probably want to use shlex here.  See
http://docs.python.org/library/shlex.html .

What I would suggest is the following: scan the options list for "--defines" and
then look at the argument that follows.  Call shlex.split on that argument to
turn it into a list.  That should give you POSIX dequoting and argument
splitting semantics.

[Mark Mentovai, 2009-07-06 16:32:47]

Recipe!

# at top
import shlex

# before the "Build up the command" section
# The defines come in as one flat string.  Split it up into distinct arguments.
if '--defines' in options:
  defines_index = options.index('--defines')
  if defines_index + 1 < len(options):
    split_options = shlex.split(options[defines_index + 1])
    if split_options:
      options[defines_index + 1:defines_index + 2] = split_options

[dglazkov, 2009-07-06 16:33:42]

Will commit temporary fix, then figure out the shlex thing. The natives are
getting restless.