Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: webkit/build/rule_binding.py

Issue 155089: Remove any double qoutes from defines, fed into bindings generator.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/build/rule_binding.py
===================================================================
--- webkit/build/rule_binding.py (revision 19909)
+++ webkit/build/rule_binding.py (working copy)
@@ -73,7 +73,9 @@
for include_dir in include_dirs:
command.extend(['-I', include_dir])
command.append(generate_bindings)
- command.extend(options)
+ # Remove any qouble qoutes that may have gotten in here. We know that none of
+ # the options will have meaningful double qoutes.
Ben Laurie 2009/07/06 16:11:20 To defend against the possibility of a define that
+ command.extend([option.replace('"', '') for option in options])
command.extend(['--outputDir', cppdir, input])
# Do it. check_call is new in 2.5, so simulate its behavior with call and
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698