Remove any double qoutes from defines, fed into bindings generator....

webkit/build/rule_binding.py

 #!/usr/bin/python
 
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # usage: rule_binding.py INPUT CPPDIR HDIR -- INPUTS -- OPTIONS
 #
 # INPUT is an IDL file, such as Whatever.idl.
 #
@@ skipping 55 matching lines @@
   for perl_module in perl_modules:
     include_dir = os.path.dirname(perl_module)
     if not include_dir in include_dirs:
       include_dirs.append(include_dir)
 
   # Build up the command.
   command = ['perl', '-w']
   for include_dir in include_dirs:
     command.extend(['-I', include_dir])
   command.append(generate_bindings)
-  command.extend(options)
+  # Remove any qouble qoutes that may have gotten in here. We know that none of
+  # the options will have meaningful double qoutes.

[Ben Laurie, 2009/07/06 16:11:20]

To defend against the possibility of a define that defines to a string (and
hence has meaningful double quotes), how about asserting that there's no
instances of '\"' in the options?

+  command.extend([option.replace('"', '') for option in options])
   command.extend(['--outputDir', cppdir, input])
 
   # Do it.  check_call is new in 2.5, so simulate its behavior with call and
   # assert.
   return_code = subprocess.call(command)
   assert return_code == 0
 
   # Both the .cpp and .h were generated in cppdir, but if hdir is different,
   # the .h needs to move.  Copy it instead of using os.rename for maximum
   # portability in all cases.
   if cppdir != hdir:
     input_basename = os.path.basename(input)
     (root, ext) = os.path.splitext(input_basename)
     hname = 'V8%s.h' % root
     hsrc = os.path.join(cppdir, hname)
     hdst = os.path.join(hdir, hname)
     shutil.copyfile(hsrc, hdst)
     os.unlink(hsrc)
 
   return return_code
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))