Issue 15082: Add FilePath support to FileVersionInfo, fix Mac memory issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15082: Add FilePath support to FileVersionInfo, fix Mac memory issues. (Closed)

Created:
12 years ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add FilePath support to FileVersionInfo, fix Mac memory issues. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7417

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
M	base/file_version_info.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	base/file_version_info.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	base/file_version_info_mac.mm	View	1	2 chunks	+12 lines, -8 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

12 years ago (2008-12-19 19:37:05 UTC) #2

LGTM

http://codereview.chromium.org/15082/diff/201/11
File base/file_version_info_mac.mm (right):

http://codereview.chromium.org/15082/diff/201/11#newcode13
Line 13: [bundle_ retain];
oops.  good catch.

Expand Messages | Collapse Messages