Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2299)

Unified Diff: base/file_version_info.h

Issue 15082: Add FilePath support to FileVersionInfo, fix Mac memory issues. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_version_info.cc » ('j') | base/file_version_info_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info.h
===================================================================
--- base/file_version_info.h (revision 7212)
+++ base/file_version_info.h (working copy)
@@ -8,6 +8,7 @@
#include <string>
#include "base/basictypes.h"
+#include "base/file_path.h"
#include "base/scoped_ptr.h"
#ifdef OS_MACOSX
@@ -27,6 +28,9 @@
// Creates a FileVersionInfo for the specified path. Returns NULL if something
// goes wrong (typically the file does not exit or cannot be opened). The
// returned object should be deleted when you are done with it.
+ static FileVersionInfo* CreateFileVersionInfo(const FilePath& file_path);
+ // This version, taking a wstring, is deprecated and only kept around
+ // until we can fix all callers.
static FileVersionInfo* CreateFileVersionInfo(const std::wstring& file_path);
// Creates a FileVersionInfo for the current module. Returns NULL in case
@@ -77,7 +81,6 @@
VS_FIXEDFILEINFO* fixed_file_info_;
#elif defined(OS_MACOSX)
explicit FileVersionInfo(NSBundle *bundle);
- explicit FileVersionInfo(const std::wstring& file_path);
NSBundle *bundle_;
#endif
« no previous file with comments | « no previous file | base/file_version_info.cc » ('j') | base/file_version_info_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698