Add FilePath support to FileVersionInfo, fix Mac memory issues.

base/file_version_info_mac.mm

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_version_info.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"
 #include "base/string_util.h"
 
-FileVersionInfo::FileVersionInfo(const std::wstring& file_path) {
-  NSString* path = [[NSString alloc]
-      initWithCString:reinterpret_cast<const char*>(file_path.c_str())
-             encoding:NSUTF32StringEncoding];
-  bundle_ = [NSBundle bundleWithPath: path];
-}
-
 FileVersionInfo::FileVersionInfo(NSBundle *bundle) : bundle_(bundle) {
+  [bundle_ retain];

[Erik does not do reviews, 2008/12/19 19:37:05]

oops.  good catch.

 }
 
 FileVersionInfo::~FileVersionInfo() {
   [bundle_ release];
 }
 
 // static
 FileVersionInfo* FileVersionInfo::CreateFileVersionInfoForCurrentModule() {
   // TODO(erikkay): this should really use bundleForClass, but we don't have
   // a class to hang onto yet.
   NSBundle* bundle = [NSBundle mainBundle];
   return new FileVersionInfo(bundle);
 }
 
 // static
 FileVersionInfo* FileVersionInfo::CreateFileVersionInfo(
     const std::wstring& file_path) {
-  return new FileVersionInfo(file_path);
+  NSString* path = [NSString stringWithCString:
+      reinterpret_cast<const char*>(file_path.c_str())
+        encoding:NSUTF32StringEncoding];
+  return new FileVersionInfo([NSBundle bundleWithPath:path]);
+}
+
+// static
+FileVersionInfo* FileVersionInfo::CreateFileVersionInfo(
+    const FilePath& file_path) {
+  NSString* path = [NSString stringWithUTF8String:file_path.value().c_str()];
+  return new FileVersionInfo([NSBundle bundleWithPath:path]);
 }
 
 std::wstring FileVersionInfo::company_name() {
   return L"";
 }
 
 std::wstring FileVersionInfo::company_short_name() {
   return L"";
 }
 
@@ skipping 65 matching lines @@
   }
   return false;
 }
 
 std::wstring FileVersionInfo::GetStringValue(const wchar_t* name) {
   std::wstring str;
   if (GetValue(name, &str))
     return str;
   return L"";
 }