Issue 15035: Refactored the code for handling debug step in in the runtime system into one...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15035: Refactored the code for handling debug step in in the runtime system into one... (Closed)

Created:
12 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactored the code for handling debug step in in the runtime system into one function. For constructors this also means that step in will no longer step into the code for the builtins context. Committed: http://code.google.com/p/v8/source/detail?r=1001

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
M	src/debug.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+5 lines, -11 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	test/mjsunit/debug-stepin-constructor.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM! http://codereview.chromium.org/15035/diff/1/6 File src/debug.cc (right): http://codereview.chromium.org/15035/diff/1/6#newcode1117 Line 1117: if (function->context()->global() != This condition will fit ...

12 years ago (2008-12-18 14:27:26 UTC) #2

Søren Thygesen Gjesse

12 years ago (2008-12-18 14:34:07 UTC) #3

http://codereview.chromium.org/15035/diff/1/6
File src/debug.cc (right):

http://codereview.chromium.org/15035/diff/1/6#newcode1117
Line 1117: if (function->context()->global() !=
On 2008/12/18 14:27:26, Mads Ager wrote:
> This condition will fit on one line?

Yes, changed.

http://codereview.chromium.org/15035/diff/1/6#newcode1406
Line 1406: if (Debug::InDebugger()) return;
On 2008/12/18 14:27:26, Mads Ager wrote:
> Accidental edit?

Yes, reverted.

Expand Messages | Collapse Messages