Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: src/ic.cc

Issue 15035: Refactored the code for handling debug step in in the runtime system into one... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
===================================================================
--- src/ic.cc (revision 995)
+++ src/ic.cc (working copy)
@@ -352,20 +352,14 @@
if (opt->IsJSFunction()) return opt;
}
- // If performing debug step into then flood this function with one-shot
- // break points if it is called from where step into was requested.
- if (Debug::StepInActive() && fp() == Debug::step_in_fp()) {
+ // Handle stepping into a function if step into is active.
+ if (Debug::StepInActive()) {
// Protect the result in a handle as the debugger can allocate and might
// cause GC.
HandleScope scope;
- Handle<Object> result_handle(result);
- // Don't allow step into functions in the native context.
- if (JSFunction::cast(result)->context()->global() !=
- Top::context()->builtins()) {
- Handle<SharedFunctionInfo> shared(JSFunction::cast(result)->shared());
- Debug::FloodWithOneShot(shared);
- }
- return *result_handle;
+ Handle<JSFunction> function(JSFunction::cast(result));
+ Debug::HandleStepIn(function, fp(), false);
+ return *function;
}
return result;
« no previous file with comments | « src/debug.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698