Move download item to its own view and a xib, paving the way for a custom dow...

Move download item to its own view and a xib, paving the way for a custom
download item view. I didn't change the look of the download items yet. The
context menu is now in the download item xib as well.

BUG=14659, 15098, 14660
TEST=Download something. Everything should look like before (except for the smaller icon), but the context menu items should be disabled/enabled and checked/unchecked correctly.

[Nico, 2009-07-02 10:20:05]

I'm on vacation until 7/16, so no hurries with the review.

This fixes several download shelf TODOs and makes future changes (dangerous file
warnings, a custom download item look) much easier. I'm pretty happy with how
this turned out.

download_item_controller.mm could be quite a bit shorter if I stored
DownloadShelfContextMenu::SHOW_IN_FOLDER and friends in the menu item's tags,
but then there would be silent breakage if someone changes the numbers of those
constants. Since it's not _that_ much code, I'm not sure if the lost security is
worth the code savings. Opinions?

[pink (ping after 24hrs), 2009-07-06 21:45:20]

http://codereview.chromium.org/150216/diff/1048/1051
File chrome/browser/cocoa/download_item_controller.h (right):

http://codereview.chromium.org/150216/diff/1048/1051#newcode24
Line 24: scoped_ptr<DownloadShelfContextMenuMac> menu_bridge_;
objective-C naming (menuBridge) in objective-C classes.

http://codereview.chromium.org/150216/diff/1048/1051#newcode29
Line 29: download:(BaseDownloadItemModel*)download_model;
I'd name this |-initWithFrame:model:|, but that's just me.

http://codereview.chromium.org/150216/diff/1048/1051#newcode29
Line 29: download:(BaseDownloadItemModel*)download_model;
Fix param name to obj-C naming. Elsewhere in file too.

http://codereview.chromium.org/150216/diff/1048/1050
File chrome/browser/cocoa/download_item_controller.mm (right):

http://codereview.chromium.org/150216/diff/1048/1050#newcode5
Line 5: #import "download_item_controller.h"
use the full path (chrome/browser/cocoa/...)

http://codereview.chromium.org/150216/diff/1048/1050#newcode64
Line 64: FilePath download_path = download_model->download()->GetFileName();
obj-C naming for local variables. Elsewhere in the file as well.

http://codereview.chromium.org/150216/diff/1048/1050#newcode73
Line 73: [[NSWorkspace sharedWorkspace] iconForFileType:extension]];
we should use IconManager for this. We've discussed this before, when were we
planning on making it so?

http://codereview.chromium.org/150216/diff/1048/1050#newcode86
Line 86: - (BOOL)validateMenuItem:(NSMenuItem *)item {
I think it's ok to put the tags in the nib. Our main menus will already break if
they change. It also means that we don't have to make code changes every time a
new menu item is added (we just have to update the nib).

http://codereview.chromium.org/150216/diff/1048/1055
File chrome/browser/cocoa/download_shelf_controller.h (right):

http://codereview.chromium.org/150216/diff/1048/1055#newcode34
Line 34: std::vector<DownloadItemController*> download_item_controllers_;
use obj-C naming. Also, make this a NSMutableArray.

http://codereview.chromium.org/150216/diff/1048/1055#newcode46
Line 46: - (void)addDownloadItem:(BaseDownloadItemModel*)view;
is this a model or a view? The param name should probably be changed.

http://codereview.chromium.org/150216/diff/1048/1058
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/150216/diff/1048/1058#newcode163
Line 163: - (void)addDownloadItem:(BaseDownloadItemModel*)download_model {
use obj-C naming for param.

http://codereview.chromium.org/150216/diff/1048/1058#newcode173
Line 173: download_item_controllers_.push_back([[DownloadItemController alloc]
Why not use NSMutableArray? You shouldn't be putting NSObjects in a vector.