Move download item to its own view and a xib, paving the way for a custom dow...

chrome/browser/cocoa/download_shelf_controller.h

Index: chrome/browser/cocoa/download_shelf_controller.h
===================================================================
--- chrome/browser/cocoa/download_shelf_controller.h	(revision 19730)
+++ chrome/browser/cocoa/download_shelf_controller.h	(working copy)
@@ -3,11 +3,14 @@
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
+#include <vector>
 
 #include "base/scoped_ptr.h"
 
+class BaseDownloadItemModel;
 class Browser;
 @class BrowserWindowController;
+@class DownloadItemController;
 class DownloadShelf;
 @class DownloadShelfView;
 
@@ -26,6 +29,9 @@
   scoped_ptr<DownloadShelf> bridge_;
   NSView* contentArea_;
   int shelfHeight_;
+
+  // The download items we have added to our shelf.
+  std::vector<DownloadItemController*> download_item_controllers_;

[pink (ping after 24hrs), 2009/07/06 21:45:20]

use obj-C naming. Also, make this a NSMutableArray.

 };
 
 - (id)initWithBrowser:(Browser*)browser
@@ -37,9 +43,7 @@
 - (IBAction)show:(id)sender;
 - (IBAction)hide:(id)sender;
 
-// TODO(thakis): this should internally build an item and get only
-// the model as parameter.
-- (void)addDownloadItem:(NSView*)view;
+- (void)addDownloadItem:(BaseDownloadItemModel*)view;

[pink (ping after 24hrs), 2009/07/06 21:45:20]

is this a model or a view? The param name should probably be changed.

 
 // Resizes the download shelf based on the state of the content area.
 - (void)resizeDownloadShelf;