Move download item to its own view and a xib, paving the way for a custom dow...

chrome/browser/cocoa/download_shelf_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "download_shelf_controller.h"
 
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/cocoa/browser_window_controller.h"
 #include "chrome/browser/cocoa/browser_window_cocoa.h"
+#include "chrome/browser/cocoa/download_item_controller.h"
 #include "chrome/browser/cocoa/download_shelf_mac.h"
 #import "chrome/browser/cocoa/download_shelf_view.h"
 #include "grit/generated_resources.h"
 
+namespace {
+
+// TODO(thakis): These are all temporary until there's a download item view
+
+// Border padding of a download item
+const int kDownloadItemBorderPadding = 4;
+
+// Width of a download item
+const int kDownloadItemWidth = 200;
+
+// Height of a download item
+const int kDownloadItemHeight = 32;
+
+// Horizontal padding between two download items
+const int kDownloadItemPadding = 10;
+
+}  // namespace
 
 @interface DownloadShelfController(Private)
 - (void)applyContentAreaOffset:(BOOL)apply;
 - (void)positionBar;
 - (void)showDownloadShelf:(BOOL)enable;
 @end
 
 
 @implementation DownloadShelfController
 
@@ skipping 109 matching lines @@
 }
 
 - (void)show:(id)sender {
   [self showDownloadShelf:YES];
 }
 
 - (void)hide:(id)sender {
   [self showDownloadShelf:NO];
 }
 
-- (void)addDownloadItem:(NSView*)view {
-  [[self view] addSubview:view];
+- (void)addDownloadItem:(BaseDownloadItemModel*)download_model {

[pink (ping after 24hrs), 2009/07/06 21:45:20]

use obj-C naming for param.

+  // TODO(thakis): we need to delete these at some point. There's no explicit
+  // mass delete on windows, figure out where they do it.
+
+  // TODO(thakis): RTL support?
+  // (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT)
+  int startX = kDownloadItemBorderPadding +
+      (kDownloadItemWidth + kDownloadItemPadding) *
+          download_item_controllers_.size();
+
+  download_item_controllers_.push_back([[DownloadItemController alloc]

[pink (ping after 24hrs), 2009/07/06 21:45:20]

Why not use NSMutableArray? You shouldn't be putting NSObjects in a vector.

+      initWithFrame:NSMakeRect(startX, kDownloadItemBorderPadding,
+                                kDownloadItemWidth, kDownloadItemHeight)
+           download:download_model]);
+
+  [[self view] addSubview:[download_item_controllers_.back() view]];
 }
 
 @end